Page MenuHomeFreeBSD

Add aml8726-m3 usbclock support
ClosedPublic

Authored by john-feith.com on May 19 2015, 5:03 PM.
Tags
Referenced Files
Unknown Object (File)
Nov 17 2024, 2:04 PM
Unknown Object (File)
Nov 17 2024, 8:52 AM
Unknown Object (File)
Nov 11 2024, 11:07 PM
Unknown Object (File)
Sep 30 2024, 9:16 AM
Unknown Object (File)
Sep 26 2024, 2:58 PM
Unknown Object (File)
Sep 16 2024, 12:22 PM
Unknown Object (File)
Aug 2 2024, 12:02 AM
Unknown Object (File)
Jul 29 2024, 10:28 AM
Subscribers

Details

Reviewers
ganbold
Summary

The usbclock generator on the earlier amlogic chip is a bit different
so add a new driver.

Test Plan

Tested on YYHD18 (aml8726-m3).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

john-feith.com retitled this revision from to Add aml8726-m3 usbclock support.
john-feith.com updated this object.
john-feith.com edited the test plan for this revision. (Show Details)
john-feith.com added a reviewer: ganbold.
john-feith.com set the repository for this revision to rS FreeBSD src repository - subversion.
john-feith.com added a project: ARM.
sys/arm/amlogic/aml8726/aml8726_usb_phy-m3.c
254

Maybe 4 space tab?

398

Same here.

410

maybe only a tab inside DEVMETHOD instead of space and tab?

sys/arm/amlogic/aml8726/aml8726_usb_phy-m3.c
213

Is it intentional here to set err and then later check in out of the loop?

I've made the suggested changes (as well as adding break to the corresponding code in the m6 usb clock code).

I've responded to the inline comments.

sys/arm/amlogic/aml8726/aml8726_usb_phy-m3.c
213

Yes ... memory is allocated prior to the loop by OF_getencprop_alloc which is freed after the loop
(in both success as well as error states). Technically we can break out of the loop when err is set
so I've added the missing break, though no harm came from contining the loop.

ganbold edited edge metadata.
This revision is now accepted and ready to land.May 21 2015, 7:25 AM