Page MenuHomeFreeBSD

Initialize amlogic RTC based on SoC instead of DTS
ClosedPublic

Authored by john-feith.com on May 19 2015, 4:58 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Jul 13, 12:24 PM
Unknown Object (File)
Sat, Jul 5, 3:53 PM
Unknown Object (File)
Thu, Jul 3, 6:50 AM
Unknown Object (File)
Wed, Jul 2, 2:02 AM
Unknown Object (File)
Mon, Jun 30, 1:53 AM
Unknown Object (File)
Sun, Jun 29, 7:27 PM
Unknown Object (File)
Sat, Jun 28, 9:34 PM
Unknown Object (File)
Jun 10 2025, 10:57 AM
Subscribers

Details

Reviewers
ganbold
Summary

The RTC initialization values are based on the SoC which can be
determined at runtime so there's no need to set the values in
each DTS.

Test Plan

Tested on YYHD18 (aml8726-m3), VSATV102 (aml8726-m6), and
ODROIDC1 (aml8726-m8b).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

john-feith.com retitled this revision from to Initialize amlogic RTC based on SoC instead of DTS.
john-feith.com updated this object.
john-feith.com edited the test plan for this revision. (Show Details)
john-feith.com added a reviewer: ganbold.
john-feith.com set the repository for this revision to rS FreeBSD src repository - subversion.
john-feith.com added a project: ARM.
sys/arm/amlogic/aml8726/aml8726_rtc.c
396

Why would add here break?

I've made the suggested change (as well as propagating the change to other files which I've piggybacked onto this review).

I've responded to the inline comments.

ganbold edited edge metadata.
This revision is now accepted and ready to land.May 21 2015, 7:10 AM