Page MenuHomeFreeBSD

Initialize amlogic RTC based on SoC instead of DTS
ClosedPublic

Authored by john-feith.com on May 19 2015, 4:58 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Apr 10, 8:22 PM
Unknown Object (File)
Feb 23 2024, 9:28 PM
Unknown Object (File)
Feb 16 2024, 8:27 AM
Unknown Object (File)
Feb 16 2024, 7:13 AM
Unknown Object (File)
Jan 7 2024, 7:28 PM
Unknown Object (File)
Dec 20 2023, 2:48 AM
Unknown Object (File)
Nov 13 2023, 12:44 AM
Unknown Object (File)
Sep 29 2023, 8:58 PM
Subscribers

Details

Reviewers
ganbold
Summary

The RTC initialization values are based on the SoC which can be
determined at runtime so there's no need to set the values in
each DTS.

Test Plan

Tested on YYHD18 (aml8726-m3), VSATV102 (aml8726-m6), and
ODROIDC1 (aml8726-m8b).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

john-feith.com retitled this revision from to Initialize amlogic RTC based on SoC instead of DTS.
john-feith.com updated this object.
john-feith.com edited the test plan for this revision. (Show Details)
john-feith.com added a reviewer: ganbold.
john-feith.com set the repository for this revision to rS FreeBSD src repository - subversion.
john-feith.com added a project: ARM.
sys/arm/amlogic/aml8726/aml8726_rtc.c
396

Why would add here break?

I've made the suggested change (as well as propagating the change to other files which I've piggybacked onto this review).

I've responded to the inline comments.

ganbold edited edge metadata.
This revision is now accepted and ready to land.May 21 2015, 7:10 AM