Page MenuHomeFreeBSD

make set_buswide() generic
ClosedPublic

Authored by br on Tue, Jul 28, 1:35 PM.

Details

Summary

Rename these functions:

bus_dma_dmar_set_buswide()
dmar_is_buswide_ctx()
dmar_set_buswide_ctx()

Not really sure if they are needed for SMMU, but we need to build them on arm64 at least

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

br requested review of this revision.Tue, Jul 28, 1:35 PM
br created this revision.
br updated this revision to Diff 75068.Tue, Jul 28, 2:44 PM

Rename bus_dma_dmar_load_ident() as well

kib accepted this revision.Tue, Jul 28, 3:40 PM

So please plan for the following two next changes:

  1. Removal of headers from iommu.h
  2. Providing the vtable for implementation of map/unmap to be used from iommu_gas.
sys/dev/iommu/iommu.h
41 ↗(On Diff #75068)

sys/types.h should go first.

43 ↗(On Diff #75068)

I think that bringing all that headers into iommu.h was the wrong idea. All of that should be removed and provided by the header' consumers.

This revision is now accepted and ready to land.Tue, Jul 28, 3:40 PM