Page MenuHomeFreeBSD
Differential D25852

make set_buswide() generic
ClosedPublic
Actions

Authored by br on Jul 28 2020, 1:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 6:07 PM
Unknown Object (File)
Tue, Nov 12, 11:06 PM
Unknown Object (File)
Tue, Nov 12, 4:09 AM
Unknown Object (File)
Tue, Nov 12, 2:31 AM
Unknown Object (File)
Mon, Nov 11, 10:58 PM
Unknown Object (File)
Sun, Nov 10, 11:13 PM
Unknown Object (File)
Sun, Nov 10, 4:55 PM
Unknown Object (File)
Sun, Nov 10, 2:11 PM
View All 34 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS363650: o Move the buswide_ctxs bitmap to iommu_unit and rename related functions.
Summary

Rename these functions:

bus_dma_dmar_set_buswide()
dmar_is_buswide_ctx()
dmar_set_buswide_ctx()

Not really sure if they are needed for SMMU, but we need to build them on arm64 at least

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

br requested review of this revision.Jul 28 2020, 1:35 PM
br created this revision.
br updated this revision to Diff 75068.Jul 28 2020, 2:44 PM

Rename bus_dma_dmar_load_ident() as well

kib accepted this revision.Jul 28 2020, 3:40 PM

So please plan for the following two next changes:

  1. Removal of headers from iommu.h
  2. Providing the vtable for implementation of map/unmap to be used from iommu_gas.
sys/dev/iommu/iommu.h
41 ↗(On Diff #75068)

sys/types.h should go first.

43 ↗(On Diff #75068)

I think that bringing all that headers into iommu.h was the wrong idea. All of that should be removed and provided by the header' consumers.

This revision is now accepted and ready to land.Jul 28 2020, 3:40 PM
Closed by commit rS363650: o Move the buswide_ctxs bitmap to iommu_unit and rename related functions. (authored by br). · Explain WhyJul 28 2020, 4:08 PM
This revision was automatically updated to reflect the committed changes.
br added a commit: rS363650: o Move the buswide_ctxs bitmap to iommu_unit and rename related functions..
Herald added a subscriber: imp. · View Herald TranscriptJul 28 2020, 4:08 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
iommu/
8 lines
12 lines
ntb/
ntb_hw/
2 lines
2 lines
x86/
include/
4 lines
iommu/
8 lines
13 lines
13 lines
x86/
4 lines

Diff 75077

View Options

head/sys/dev/iommu/busdma_iommu.c

Loading...
View Options

head/sys/dev/iommu/iommu.h

Loading...
View Options

head/sys/dev/ntb/ntb_hw/ntb_hw_intel.c

Loading...
View Options

head/sys/dev/ntb/ntb_hw/ntb_hw_plx.c

Loading...
View Options

head/sys/x86/include/bus_dma.h

Loading...
View Options

head/sys/x86/iommu/intel_ctx.c

Loading...
View Options

head/sys/x86/iommu/intel_dmar.h

Loading...
View Options

head/sys/x86/iommu/intel_drv.c

Loading...
View Options

head/sys/x86/x86/busdma_machdep.c

Loading...