Correct a type-mismatch between xdr_long and the variable "bad".
ClosedPublic
Actions

Authored by brooks on Jul 22 2020, 10:05 PM.

Details

Reviewers

Commits

rS363626: MFC r363439:
rS363625: MFC r363439:
rS363439: Correct a type-mismatch between xdr_long and the variable "bad".

Summary

Way back in r28911 (August 1997, CVS rev 1.22) we imported a NetBSD
information leak fix via OpenBSD. Unfortunatly we failed to track the
followup commit that fixed the type of the error code. Apply the change
from int to long now.

This bug was rediscovered on CheriBSD where hardware bounds make it a
fault.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Jul 22 2020, 10:05 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 22 2020, 10:05 PM

brooks requested review of this revision.Jul 22 2020, 10:05 PM

Harbormaster completed remote builds in B32497: Diff 74821.Jul 22 2020, 10:05 PM

emaste accepted this revision.Jul 22 2020, 10:32 PM

This revision is now accepted and ready to land.Jul 22 2020, 10:32 PM

Closed by commit rS363439: Correct a type-mismatch between xdr_long and the variable "bad". (authored by brooks). · Explain WhyJul 22 2020, 11:40 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS363439: Correct a type-mismatch between xdr_long and the variable "bad"..

brooks added a commit: rS363625: MFC r363439:.Jul 27 2020, 11:18 PM

brooks added a commit: rS363626: MFC r363439:.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

mountd/

mountd.c

3 lines

Diff 74828

View Options

head/usr.sbin/mountd/mountd.c

Correct a type-mismatch between xdr_long and the variable "bad".ClosedPublicActions