Page MenuHomeFreeBSD

Fix potential race condition in linux stat(2)
ClosedPublic

Authored by trasz on Jul 11 2020, 1:19 PM.
Tags
None
Referenced Files
F132648258: D25618.id78510.diff
Sat, Oct 18, 6:00 PM
F132648254: D25618.id74301.diff
Sat, Oct 18, 6:00 PM
Unknown Object (File)
Sat, Oct 18, 7:20 AM
Unknown Object (File)
Sun, Oct 12, 4:59 AM
Unknown Object (File)
Wed, Oct 8, 8:15 PM
Unknown Object (File)
Mon, Oct 6, 4:09 PM
Unknown Object (File)
Sep 14 2025, 11:35 PM
Unknown Object (File)
Sep 11 2025, 7:06 AM
Subscribers

Details

Summary

Fix potential race condition in linux stat(2).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz requested review of this revision.Jul 11 2020, 1:19 PM
sys/compat/linux/linux_util.c
206 ↗(On Diff #74301)

Can we use vnode lock to guarantee liveness of the v_rdev read ? This is how it was intended.

sys/compat/linux/linux_util.c
206 ↗(On Diff #74301)

Do we need to? I've looked at vn_isdisk(), and it doesn't seem to use the vnode lock.

kib added inline comments.
sys/compat/linux/linux_util.c
206 ↗(On Diff #74301)

It uses dev_mtx, same as you did, which is global and already contended mutex.

Ok, it probably would be better to do the global sweep for vn_isdisk(), finishing mjg half-done change.

This revision is now accepted and ready to land.Oct 20 2020, 1:45 PM
This revision was automatically updated to reflect the committed changes.