Differential D25618

Fix potential race condition in linux stat(2)
ClosedPublic
Actions

Authored by trasz on Jul 11 2020, 1:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 2, 1:03 AM

	Unknown Object (File)
	Mon, Aug 31, 9:46 AM

	Unknown Object (File)
	Fri, Aug 28, 1:43 PM

	Unknown Object (File)
	Tue, Aug 25, 7:20 PM

	Unknown Object (File)
	Mon, Aug 24, 1:58 AM

	Unknown Object (File)
	Fri, Aug 21, 3:50 PM

	Unknown Object (File)
	Fri, Aug 21, 3:21 AM

	Unknown Object (File)
	Thu, Aug 20, 11:02 PM

Subscribers

Details

Reviewers

Commits

rS366899: Fix potential race condition in linux stat(2).

Summary

Fix potential race condition in linux stat(2).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Jul 11 2020, 1:19 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 11 2020, 1:19 PM

Harbormaster completed remote builds in B32238: Diff 74301.Jul 11 2020, 1:19 PM

trasz requested review of this revision.Jul 11 2020, 1:19 PM

(Tinderboxed.)

kib added inline comments.Sep 14 2020, 10:55 AM

sys/compat/linux/linux_util.c
206 ↗	(On Diff #74301)	Can we use vnode lock to guarantee liveness of the v_rdev read ? This is how it was intended.

trasz added inline comments.Oct 16 2020, 3:21 PM

sys/compat/linux/linux_util.c
206 ↗	(On Diff #74301)	Do we need to? I've looked at vn_isdisk(), and it doesn't seem to use the vnode lock.

kib accepted this revision.Oct 20 2020, 1:45 PM

kib added inline comments.

sys/compat/linux/linux_util.c
206 ↗	(On Diff #74301)	It uses dev_mtx, same as you did, which is global and already contended mutex. Ok, it probably would be better to do the global sweep for vn_isdisk(), finishing mjg half-done change.

This revision is now accepted and ready to land.Oct 20 2020, 1:45 PM

Closed by commit rS366899: Fix potential race condition in linux stat(2). (authored by trasz). · Explain WhyOct 20 2020, 5:19 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS366899: Fix potential race condition in linux stat(2)..

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linux/

9 lines

1 line

19 lines

Diff 78510

head/sys/compat/linux/linux_stats.c

Loading...

head/sys/compat/linux/linux_util.h

Loading...

head/sys/compat/linux/linux_util.c

Loading...