Page MenuHomeFreeBSD
Differential D2551

sfxge: get rid of locked variable in sfxge_tx_packet_add()
ClosedPublic
Actions

Authored by arybchik on May 15 2015, 6:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 10:10 AM
Unknown Object (File)
Thu, Oct 9, 3:07 AM
Unknown Object (File)
Tue, Sep 30, 9:04 PM
Unknown Object (File)
Aug 22 2025, 12:46 PM
Unknown Object (File)
Aug 22 2025, 8:17 AM
Unknown Object (File)
Aug 20 2025, 2:18 AM
Unknown Object (File)
Aug 17 2025, 8:15 PM
Unknown Object (File)
Jul 18 2025, 9:18 PM
View All 91 Files
Subscribers
imp
network

Details

Reviewers
gnn
Commits
rS282997: sfxge: get rid of locked variable in sfxge_tx_packet_add()
Summary

Now each branch has one and only one possible TxQ lock state.
It simplifies understanding of the code.

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

Build tested. Module loaded. Tested under UDP stream traffic,
checked that both branches work fine.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik updated this revision to Diff 5399.May 15 2015, 6:55 AM
arybchik retitled this revision from to sfxge: get rid of locked variable in sfxge_tx_packet_add().
arybchik updated this object.
arybchik edited the test plan for this revision. (Show Details)
arybchik added a reviewer: gnn.
Herald added a subscriber: imp. · View Herald TranscriptMay 15 2015, 6:55 AM
arybchik added a subscriber: network.May 15 2015, 6:56 AM
gnn accepted this revision.May 15 2015, 6:42 PM
gnn edited edge metadata.
This revision is now accepted and ready to land.May 15 2015, 6:42 PM
Closed by commit rS282997: sfxge: get rid of locked variable in sfxge_tx_packet_add() (authored by arybchik). · Explain WhyMay 16 2015, 5:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
20 lines

Diff 5419

View Options

head/sys/dev/sfxge/sfxge_tx.c

Loading...