sfxge: do not change CSUM_TSO when IFCAP_TSOx is changed
ClosedPublic
Actions

Authored by arybchik on May 14 2015, 2:51 PM.

Details

Reviewers

Commits

rS282941: sfxge: do not change CSUM_TSO when IFCAP_TSOx is changed

Summary

It is simply not required since the kernel checks corresponding
IFCAP_TSOx capability and CSUM_TSO in hw-assisted offloads.
Note that CSUM_TSO is two bits (CSUM_IP_TSO|CSUM_IP6_TSO) and both bits
are set in IPv4 and IPv6 mbufs.

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

Driver build tested. Module loaded.
TSO4/6 enable/disable tested.
CSUM flags are checked in Tx mbufs.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik updated this revision to Diff 5385.May 14 2015, 2:51 PM

arybchik retitled this revision from to sfxge: do not change CSUM_TSO when IFCAP_TSOx is changed.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added a reviewer: gnn.

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2015, 2:51 PM

arybchik added a subscriber: network.May 14 2015, 2:52 PM

gnn accepted this revision.May 14 2015, 8:08 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.May 14 2015, 8:08 PM

Closed by commit rS282941: sfxge: do not change CSUM_TSO when IFCAP_TSOx is changed (authored by arybchik). · Explain WhyMay 15 2015, 6:49 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

sfxge.c

12 lines

Diff 5397

View Options

head/sys/dev/sfxge/sfxge.c

sfxge: do not change CSUM_TSO when IFCAP_TSOx is changedClosedPublicActions