Page MenuHomeFreeBSD
Differential D2540

sfxge: avoid usage of ifm_data
ClosedPublic
Actions

Authored by arybchik on May 14 2015, 12:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 12:28 AM
Unknown Object (File)
Sun, Sep 28, 4:17 PM
Unknown Object (File)
Sat, Sep 27, 2:10 AM
Unknown Object (File)
Mon, Sep 22, 6:08 AM
Unknown Object (File)
Sun, Sep 21, 8:06 AM
Unknown Object (File)
Sat, Sep 20, 8:42 PM
Unknown Object (File)
Sat, Sep 20, 4:26 PM
Unknown Object (File)
Sat, Sep 20, 4:07 PM
View All 93 Files
Subscribers
imp
network

Details

Reviewers
glebius
Commits
rS283007: sfxge: avoid usage of ifm_data
Summary

The driver uses ifm_data to save capabilities mask calculated during
initialization when supported phy modes are discovered.
The patch simply calculates it when either media or options are changed.

Test Plan

Build tested. Driver loaded.
ifconfig -m sfxge0 tested.
Media and mediaopts changes tested.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik updated this revision to Diff 5373.May 14 2015, 12:46 PM
arybchik retitled this revision from to sfxge: avoid usage of ifm_data.
arybchik updated this object.
arybchik edited the test plan for this revision. (Show Details)
arybchik added a reviewer: glebius.
Herald added a subscriber: imp. · View Herald TranscriptMay 14 2015, 12:46 PM
arybchik added a subscriber: network.May 14 2015, 12:49 PM
glebius accepted this revision.May 16 2015, 8:48 AM
glebius edited edge metadata.

Looks more complex than the initial patch, but since achieves the same - removal of ifm_data, I vote for it. Thanks a lot! :)

This revision is now accepted and ready to land.May 16 2015, 8:48 AM
Closed by commit rS283007: sfxge: avoid usage of ifm_data (authored by arybchik). · Explain WhyMay 16 2015, 10:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
132 lines

Diff 5426

View Options

head/sys/dev/sfxge/sfxge_port.c

Loading...