lang/python34: fix build with LibreSSL and without NLS
AbandonedPublic
Actions

Authored by miwi on May 12 2015, 6:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 24, 1:27 AM

	Unknown Object (File)
	Nov 13 2024, 7:05 AM

	Unknown Object (File)
	Oct 12 2024, 3:49 AM

	Unknown Object (File)
	Sep 29 2024, 3:15 AM

	Unknown Object (File)
	Sep 1 2024, 3:17 PM

	Unknown Object (File)
	Aug 12 2024, 1:29 PM

	Unknown Object (File)
	Jul 2 2024, 2:17 PM

	Unknown Object (File)
	Apr 26 2024, 9:40 AM

View All 45 Files

Subscribers

brnrd

sunpoet

Details

Reviewers

xmj
koobs

Group Reviewers

Python

Summary

lang/python34 flakes when building *with* LibreSSL and *without* NLS.
This most likely slipped through because NLS is enabled by default,
and nobody turns it off anyway.

Test Plan

poudriere log with NLS turned off, after patch
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=156724

poudriere log with NLS turned on, after patch
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=156725

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

xmj updated this revision to Diff 5350.May 12 2015, 6:57 PM

xmj retitled this revision from to lang/python34: fix build with LibreSSL and without NLS.

xmj updated this object.

xmj edited the test plan for this revision. (Show Details)

xmj added a reviewer: Python.

koobs commandeered this revision.Jul 3 2015, 9:18 AM

koobs added a reviewer: xmj.

Instead of adding ${LOCALBASE}/lib unconditionally, would it be better to use ${OPENSSLLIB}?

My system built the current port with
OPTIONS_UNSET+= NLS

and the LibreSSL fix is in the port as well.

python34 is gone.

Revision Contents
Changeset List

Path

Size

lang/

python34/

Makefile

3 lines

Diff 5350

View Options

lang/python34: fix build with LibreSSL and without NLSAbandonedPublicActions