Page MenuHomeFreeBSD

lang/python34: fix build with LibreSSL and without NLS
AbandonedPublic

Authored by miwi on May 12 2015, 6:57 PM.

Details

Reviewers
xmj
koobs
Group Reviewers
Python
Summary

lang/python34 flakes when building *with* LibreSSL and *without* NLS.
This most likely slipped through because NLS is enabled by default,
and nobody turns it off anyway.

Test Plan

poudriere log with NLS turned off, after patch
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=156724

poudriere log with NLS turned on, after patch
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=156725

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

xmj updated this revision to Diff 5350.May 12 2015, 6:57 PM
xmj retitled this revision from to lang/python34: fix build with LibreSSL and without NLS.
xmj updated this object.
xmj edited the test plan for this revision. (Show Details)
xmj added a reviewer: Python.
koobs commandeered this revision.Jul 3 2015, 9:18 AM
koobs added a reviewer: xmj.

Instead of adding ${LOCALBASE}/lib unconditionally, would it be better to use ${OPENSSLLIB}?

brnrd added a subscriber: brnrd.Jan 2 2016, 7:11 PM

My system built the current port with
OPTIONS_UNSET+= NLS

and the LibreSSL fix is in the port as well.

miwi commandeered this revision.Feb 1 2019, 4:51 PM
miwi abandoned this revision.
miwi added a reviewer: koobs.

python34 is gone.