math/cocoalib: Update to 0.99710
ClosedPublic
Actions

Authored by salvadore on Jun 11 2020, 3:29 PM.

Details

Reviewers

gerald
tcberner

Commits

rP538535: math/cocoalib: Update to 0.99710

Summary

Also:

build the port by patching existing Makefiles instead of copying a new one from ${FILESDIR} in the hope that this eases maintainance;
change the SMALLDEG option so that it now applies a patch conditionally instead of using ${REINPLACE_CMD}.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

salvadore created this revision.Jun 11 2020, 3:29 PM

Herald added a subscriber: mat. · View Herald TranscriptJun 11 2020, 3:29 PM

salvadore requested review of this revision.Jun 11 2020, 3:29 PM

Harbormaster completed remote builds in B31639: Diff 72987.Jun 11 2020, 3:29 PM

Okay.

Is there anything suitable for upstream submission/inclusion admit all those Makefile changes? Would be nice to not have that big of a patchset long term.

This revision is now accepted and ready to land.Jun 11 2020, 5:30 PM

Unfortunately I think it is very unlikely that thoses patches can be merged upstream: I have introduced them because their build system is very complicate to use on FreeBSD (and I guess on Linux as well as soon as something is non standard) and I found easier to completely bypass it. What upstream should do, in my opinion, is redesigning it from scratch, but this would need much more work than my patches and I think they lack the time to deal with it.

Closed by commit rP538535: math/cocoalib: Update to 0.99710 (authored by salvadore). · Explain WhyJun 11 2020, 8:22 PM

This revision was automatically updated to reflect the committed changes.

salvadore added a commit: rP538535: math/cocoalib: Update to 0.99710.