Page MenuHomeFreeBSD

Fetch editors/vim distfile from github
ClosedPublic

Authored by feld on May 12 2015, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 10 2024, 3:26 PM
Unknown Object (File)
Mar 10 2024, 3:05 PM
Unknown Object (File)
Feb 22 2024, 8:50 AM
Unknown Object (File)
Feb 19 2024, 10:32 PM
Unknown Object (File)
Feb 19 2024, 10:32 PM
Unknown Object (File)
Feb 19 2024, 10:32 PM
Unknown Object (File)
Feb 19 2024, 10:32 PM
Unknown Object (File)
Feb 19 2024, 10:18 PM
Subscribers

Details

Reviewers
sunpoet
mat
Group Reviewers
portmgr
Summary

Reduce number of distfiles for editors/vim to one (1) by fetching from
github.

This is left at the same patchlevel (712) to allow merging to quarterly
branch to ease the pain there as well.

Test Plan

Build with poudriere testport both editors/vim and editors/vim-lite

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

feld retitled this revision from to Fetch editors/vim distfile from github.
feld updated this object.
feld edited the test plan for this revision. (Show Details)
feld added reviewers: mat, sunpoet.

remove vim from bsd.sites.mk
remove unused if statement from post-patch

bdrewery added inline comments.
editors/vim/Makefile
33

It defaults to PORTNAME

36

Instead of these 4 lines just use WRKSRC_SUBDIR=src, no need to modify WRKSRC either.

feld marked an inline comment as done.
feld edited edge metadata.

No need to define WRKSRC
Github project/author values derived from PORTNAME

editors/vim/Makefile
36

WRKSRC_SUBDIR appears to create a lot of casualties:

  • patches in files/ need to be adjusted
  • lots of ${WRKSRC}/src below need to be changed
  • ${WRKSRC}/runtime below won't work; need to hack something like ${WRKSRC%/${WRKSRC_SUBDIR}}/runtime

Is this worth it?

feld marked 2 inline comments as done.May 12 2015, 5:07 PM
feld added inline comments.
editors/vim/Makefile
36

WRKSRC doesn't even need to be defined.

feld marked 2 inline comments as done.May 12 2015, 5:07 PM
sunpoet edited edge metadata.

Committed. Thanks!

This revision is now accepted and ready to land.May 16 2015, 5:16 AM

This was committed a while back.