Page MenuHomeFreeBSD
Differential D2512

SCSI disk hot add and remove on Hyper-V
ClosedPublic
Actions

Authored by whu on May 11 2015, 7:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 3:17 AM
Unknown Object (File)
Dec 1 2023, 7:56 AM
Unknown Object (File)
Nov 30 2023, 7:56 PM
Unknown Object (File)
Nov 30 2023, 7:45 AM
Unknown Object (File)
Nov 29 2023, 7:39 AM
Unknown Object (File)
Nov 8 2023, 10:36 AM
Unknown Object (File)
Nov 4 2023, 10:42 PM
Unknown Object (File)
Nov 2 2023, 1:12 AM
View All 66 Files
Subscribers
gibbs
imp

Details

Reviewers
royger
Commits
rS283053: Add support for SCSI disk hot add and remove. Also add padding according to
Summary

Add support for SCSI disk hot add and remove. Also add padding
according to requirement of different hypervisors.

Test Plan

Tested by OSTC test team.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

whu updated this revision to Diff 5320.May 11 2015, 7:15 AM
whu retitled this revision from to SCSI disk hot add and remove on Hyper-V.
whu updated this object.
whu edited the test plan for this revision. (Show Details)
whu added a reviewer: royger.
whu added a subscriber: gibbs.
Herald added a subscriber: imp. · View Herald TranscriptMay 11 2015, 7:15 AM
royger edited edge metadata.May 16 2015, 9:36 AM

Only one minor comment.

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
400

Would it make sense to have a macro that calculates the size? I see you are using this in a bunch of places:

#define VSTOR_PKT_SIZE (sizeof(struct vstor_packet) - vmscsi_size_delta)

whu updated this revision to Diff 5448.May 18 2015, 9:37 AM
whu edited edge metadata.
  • Incorporate review comments from rogyer.
royger accepted this revision.May 18 2015, 10:10 AM
royger edited edge metadata.

Looks fine to me.

This revision is now accepted and ready to land.May 18 2015, 10:10 AM
Closed by commit rS283053: Add support for SCSI disk hot add and remove. Also add padding according to (authored by whu). · Explain WhyMay 18 2015, 10:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
storvsc/
96 lines
25 lines

Diff 5320

View Options

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

Loading...
View Options

sys/dev/hyperv/storvsc/hv_vstorage.h

Loading...