Page MenuHomeFreeBSD

SCSI disk hot add and remove on Hyper-V
ClosedPublic

Authored by whu on May 11 2015, 7:15 AM.

Details

Summary

Add support for SCSI disk hot add and remove. Also add padding
according to requirement of different hypervisors.

Test Plan

Tested by OSTC test team.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

whu retitled this revision from to SCSI disk hot add and remove on Hyper-V.
whu updated this object.
whu edited the test plan for this revision. (Show Details)
whu added a reviewer: royger.
whu added a subscriber: gibbs.

Only one minor comment.

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
400 ↗(On Diff #5320)

Would it make sense to have a macro that calculates the size? I see you are using this in a bunch of places:

#define VSTOR_PKT_SIZE (sizeof(struct vstor_packet) - vmscsi_size_delta)

whu edited edge metadata.
  • Incorporate review comments from rogyer.
royger edited edge metadata.

Looks fine to me.

This revision is now accepted and ready to land.May 18 2015, 10:10 AM
This revision was automatically updated to reflect the committed changes.