Page MenuHomeFreeBSD

Skyzaller crash found by Michael Tuexen
ClosedPublic

Authored by rrs on May 25 2020, 1:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 4 2024, 10:57 AM
Unknown Object (File)
Sep 22 2024, 12:34 PM
Unknown Object (File)
Sep 17 2024, 7:46 AM
Unknown Object (File)
Sep 12 2024, 10:38 AM
Unknown Object (File)
Sep 3 2024, 12:40 PM
Unknown Object (File)
Sep 3 2024, 4:05 AM
Unknown Object (File)
Aug 29 2024, 3:16 PM
Unknown Object (File)
Jul 29 2024, 12:23 AM
Subscribers

Details

Summary

Michael was able to get skyzaller to cause rack to crash with a lot of strange 0 byte send map entries. This
is because the snd_nxt was not being properly handled in the non FO case. This fixes that and
provides a small tweak to BBR as well (though I don't think this is the root cause of the bbr
Michael ran across too).

Test Plan

Run skyzaller for +100 hours to make sure it does not "rediscover" the bug/crash.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rrs requested review of this revision.May 25 2020, 1:44 PM
rrs created this revision.
This revision is now accepted and ready to land.May 25 2020, 1:59 PM

(syzkaller, not skyzaller. it does syztem kalls. nothing to do with the sky :D)

Question: You are introducting the flag RACK_HAS_SIN and you are setting it. But you are never reading it. Is that intended?

Ok turns out skyzaller has found yet another crash having to do with TFO for all three stacks. Lets update
the patch to fix that too.

This revision now requires review to proceed.May 29 2020, 1:36 PM
This revision is now accepted and ready to land.Jun 3 2020, 12:10 PM