games/lugaru: Update to 1.2
ClosedPublic
Actions

Authored by salvadore on May 25 2020, 12:30 AM.

Details

Reviewers

gerald
tcberner

Commits

rP536662: games/lugaru: Update to 1.2

Summary

Switch to gitlab repo, where the game is actually maintained.
Bump PORTEPOCH as the versioning scheme changed.
Update license information.
Switch to sdl2.
Remove obsolete DESKTOP_ENTRIES and link from share/pixmaps: the software now provides a lugaru.desktop file and an icon in share/icons.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

salvadore created this revision.May 25 2020, 12:30 AM

Herald added a subscriber: mat. · View Herald TranscriptMay 25 2020, 12:30 AM

salvadore requested review of this revision.May 25 2020, 12:30 AM

Harbormaster completed remote builds in B31281: Diff 72210.May 25 2020, 12:30 AM

tcberner added inline comments.May 25 2020, 4:19 AM

head/games/lugaru/Makefile
20	^ while I'm a big fan of alphabetizing, and would always require it in new ports. This change will likely get argued ower to only introduce "churn" -- when you actually will add a new lib-depend, that's the time for the cleanup. I would keep it unsorted.

Fixed sorting.
Thanks!

Harbormaster completed remote builds in B31290: Diff 72225.May 25 2020, 9:49 AM

salvadore marked an inline comment as done.May 25 2020, 9:50 AM

I believe this is good to go.

This revision is now accepted and ready to land.May 26 2020, 10:41 PM

Closed by commit rP536662: games/lugaru: Update to 1.2 (authored by salvadore). · Explain WhyMay 26 2020, 11:08 PM

This revision was automatically updated to reflect the committed changes.

salvadore added a commit: rP536662: games/lugaru: Update to 1.2.

Committed with a small change: head/games/lugaru/files/patch-CMakeLists.txt had both fbsd:nokeywords and svn:keywords defined so I had to remove svn:keywords.