Differential D2472

Patch to add missing Amlogic pic barriers
ClosedPublic
Actions

Authored by john-feith.com on May 7 2015, 5:07 PM.

Details

Reviewers

ganbold

Summary

This follows the gic and ti/aintc code by adding additional barriers to the
Amlogic pic driver.

Test Plan

Tested on YYHD18 (aml8726-m3 SoC) ... config files coming soon.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

john-feith.com updated this revision to Diff 5259.May 7 2015, 5:07 PM

john-feith.com retitled this revision from to Patch to add missing Amlogic pic barriers.

john-feith.com updated this object.

john-feith.com edited the test plan for this revision. (Show Details)

john-feith.com added a reviewer: ganbold.

john-feith.com set the repository for this revision to rS FreeBSD src repository - subversion.

john-feith.com added a project: ARM.

Herald added subscribers: imp, andrew. · View Herald TranscriptMay 7 2015, 5:07 PM

Does arm_mask_irq() also need arm_irq_memory_barrier(nb) ?

I don't believe so and the gic as well as the ti/aintc arm_mask_irq routines
do not currently call arm_irq_memory_barrier.

The intent of arm_irq_memory_barrier is to ensure any device driver writes
have hit the hardware (thus clearing the device's interrupt line) before
the interrupt controller unmasks the interrupt.

ganbold accepted this revision.May 8 2015, 4:34 AM

ganbold edited edge metadata.

This revision is now accepted and ready to land.May 8 2015, 4:34 AM

ganbold closed this revision.May 8 2015, 4:38 AM

Revision Contents
Changeset List

Path

Size

sys/

arm/

amlogic/

aml8726/

aml8726_pic.c

6 lines

Diff 5259

View Options

sys/arm/amlogic/aml8726/aml8726_pic.c

Patch to add missing Amlogic pic barriersClosedPublicActions