Details
- Reviewers
mandree - Commits
- rP535790: databases/foundationdb-devel: bump version and add TLS
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 30865 Build 28582: arc lint + arc unit
Event Timeline
drop all the TLS option garbage and use newer CMAKE flag now that
upstream supports OpenSSL as well
Builds for me in poudriere bulk
12.1-RELEASE-p4 amd64 and
11.3-RELEASE-p7 amd64.
No run-time tests performed.
With poudriere testport or poudriere bulk -t, this exposes framework bugs:
[01:24:38] =>> Checking for filesystem violations... done
[01:24:41] =>> Error: Filesystem touched during build:
[01:24:41] extra: usr/local/etc/mono/registry
[01:24:41] build of databases/foundationdb-devel | foundationdb-devel-7.0.0.a.20200502 ended at Sat May 2 17:52:51 CEST 2020
So the crucial change is telling the upstream code that it is a Bad Idea™ to try and link libssl.a libcrypto.a statically when you are in fact just trying to link a dynamic library. That is what our change in cmake/FDBComponents.cmake achieves, replace OPENSSL_USE_STATIC_LIBS TRUE by ... FALSE