node12: Fix build on armv6 and armv7
ClosedPublic
Actions

Authored by loader on Apr 29 2020, 1:58 AM.

Details

Reviewers

koobs
bhughes

Commits

rP533774: MFH: r533741
rP533741: www/node, www/node12: Fix build on armv6 and armv7

Summary

https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/20200405/1434551.html
https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/20200405/1434713.html
https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/20200402/1432931.html
https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/20200402/1433083.html

-latomic was introduced by this commit
https://github.com/nodejs/node/commit/1bc7a50fdd203de2e1c3842f98525d7cd97a3cdd

Proposed commit log message:

www/node, www/node12: Fix build on armv6 and armv7

Reviewed_by: koobs, bhughes
Approved by: koobs (ports, mentor), bhughes (maintainer)
Differential_Revision: D24612
MFH: 2020Q2

Test Plan

portlint: (WARN: Makefile: "USES" has to appear earlier. 0 fatal errors and 1 warning found.)
testport: OK (poudriere: 1300091, [armv6, armv7, i386, amd64, aarch64], '', tested)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 30787
Build 28511: arc lint + arc unit

Event Timeline

loader created this revision.Apr 29 2020, 1:58 AM

Herald added a subscriber: mat. · View Herald TranscriptApr 29 2020, 1:58 AM

loader requested review of this revision.Apr 29 2020, 1:58 AM

Harbormaster completed remote builds in B30787: Diff 71135.Apr 29 2020, 1:58 AM

loader edited the summary of this revision. (Show Details)Apr 29 2020, 2:05 AM

Thanks @loader

If quarterly is also affected (I assume it is), please add MFH: 2020Q2 to commit log message
If there are any existing open Bugzilla issues, please include PR: references as well
Re QA, if you haven't already please confirm that !arm architectures also successfully build with this change

This revision is now accepted and ready to land.Apr 29 2020, 3:01 AM

bhughes accepted this revision.Apr 29 2020, 4:16 AM

loader edited the summary of this revision. (Show Details)May 3 2020, 3:04 AM

loader edited the test plan for this revision. (Show Details)