emulators/i386-wine-devel: Simplify PLIST variables
ClosedPublic
Actions

Authored by salvadore on Apr 28 2020, 7:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 8, 4:53 PM

	Unknown Object (File)
	Sat, Aug 8, 1:44 PM

	Unknown Object (File)
	Sat, Aug 8, 9:56 AM

	Unknown Object (File)
	Fri, Aug 7, 6:46 PM

	Unknown Object (File)
	Fri, Aug 7, 6:13 AM

	Unknown Object (File)
	Tue, Aug 4, 8:26 AM

	Unknown Object (File)
	Tue, Aug 4, 7:27 AM

	Unknown Object (File)
	Mon, Aug 3, 6:57 AM

View All Files

Subscribers

mat

Details

Reviewers

gerald
tcberner

Commits

rP533267: emulators/i386-wine-devel: Simplify PLIST variables

Summary

Remove *DEVEL PLIST variables as they are now meaningless.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

salvadore created this revision.Apr 28 2020, 7:05 PM

Herald added a subscriber: mat. · View Herald TranscriptApr 28 2020, 7:05 PM

salvadore requested review of this revision.Apr 28 2020, 7:05 PM

Harbormaster completed remote builds in B30779: Diff 71121.Apr 28 2020, 7:05 PM

Sorry mentors: I missed those lines in the precedent commit.

lgtm

head/emulators/i386-wine-devel/Makefile.amd64
26	^ for the future, I would suggest, to use indentations for the if/for when nested, but that is not related to this review :) .if foo . if bar . endif .endif

This revision is now accepted and ready to land.Apr 28 2020, 7:15 PM

Closed by commit rP533267: emulators/i386-wine-devel: Simplify PLIST variables (authored by salvadore). · Explain WhyApr 28 2020, 9:05 PM

This revision was automatically updated to reflect the committed changes.

salvadore added a commit: rP533267: emulators/i386-wine-devel: Simplify PLIST variables.

Revision Contents
Changeset List

Path

Size

head/

emulators/

i386-wine-devel/

Makefile.amd64

8 lines

Diff 71127

View Options

head/emulators/i386-wine-devel/Makefile.amd64

emulators/i386-wine-devel: Simplify PLIST variablesClosedPublicActions