Page MenuHomeFreeBSD

emulators/i386-wine-devel: Style improvements
ClosedPublic

Authored by salvadore on Apr 23 2020, 9:45 PM.

Details

Summary
  • Reorder variables.
  • Remove tools for updating pkg-plist: they were broken by precedent commits and based on the python 2 script files/mergeplist.py, but python 2 is now EOL.
  • Move port-update target from Makefile.amd64 to Makefile and rename it distinfo-update as it does not update pkg-plist anymore.
  • Remove EXTRACT_SUFX and use properly USES=tar:txz instead.
  • Remove references to removed wine staging ports in CONFLICTS_INSTALL.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Tested successfully.
It only needs a mentor approval now :)

lgtm

head/emulators/i386-wine-devel/Makefile.amd64
51

It's arguable, whether this is the right position for the options in the makefile.

This revision is now accepted and ready to land.Apr 27 2020, 5:48 PM
head/emulators/i386-wine-devel/Makefile.amd64
51

Where would you put them?
I put them there trying to follow the porter's handbook's indications: https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html

head/emulators/i386-wine-devel/Makefile.amd64
51

My gut feeling would have put them above the block where you set the PLIST_SUBs.

But I would not lose any sleep over it :)

This revision was automatically updated to reflect the committed changes.

Committed, thanks tcberner for your comments!