Page MenuHomeFreeBSD
Differential D24506

OVERLAYS: Include <overlay>/Mk/bsd.overlay.mk
ClosedPublic
Actions

Authored by bdrewery on Apr 19 2020, 9:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 25 2024, 5:49 PM
Unknown Object (File)
Sep 25 2024, 7:00 AM
Unknown Object (File)
Sep 25 2024, 2:01 AM
Unknown Object (File)
Sep 24 2024, 8:54 PM
Unknown Object (File)
Sep 24 2024, 12:08 AM
Unknown Object (File)
Sep 23 2024, 4:01 AM
Unknown Object (File)
Sep 22 2024, 11:37 PM
Unknown Object (File)
Sep 22 2024, 4:58 PM
View All 37 Files
Subscribers
mat

Details

Reviewers
bapt
mat
Group Reviewers
portmgr
Commits
rP532277: OVERLAYS: Include <overlay>/Mk/bsd.overlay.mk
Summary

This is useful for overriding the framework internals. This is
nice for testing Poudriere as well since it can mimic older
frameworks for compat testing.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bdrewery created this revision.Apr 19 2020, 9:06 PM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptApr 19 2020, 9:06 PM
Herald added a subscriber: mat. · View Herald Transcript
Harbormaster completed remote builds in B30618: Diff 70791.Apr 19 2020, 9:06 PM
bdrewery added a comment.Apr 19 2020, 9:08 PM

The test layout in Poudriere is chaos. I started converting to using OVERLAYS per test that needed special ports. bsd.overlay.mk helps with testing pre-FLAVORS support.

mat added inline comments.Apr 20 2020, 7:17 AM
Mk/bsd.port.mk
1367 ↗(On Diff #70791)

We usually use .sinclude in the ports tree, maybe it would be wise to be consistent.

bapt added inline comments.Apr 20 2020, 8:24 AM
Mk/bsd.port.mk
1367 ↗(On Diff #70791)

please use .sinclude as we don't want to fail if bsd.overlay.mk is not existing

mat added inline comments.Apr 20 2020, 8:52 AM
Mk/bsd.port.mk
1367 ↗(On Diff #70791)

Well, .-include is the same as .sinclude. (Yes, I did not know .-include existed before today either.)

bdrewery updated this revision to Diff 70809.Apr 20 2020, 4:56 PM

Use .sinclude for consistency

Harbormaster completed remote builds in B30630: Diff 70809.Apr 20 2020, 4:56 PM
mat signed these changes with MFA.Apr 21 2020, 6:58 AM
mat accepted this revision.
This revision is now accepted and ready to land.Apr 21 2020, 6:58 AM
bapt accepted this revision.Apr 21 2020, 7:54 AM
Closed by commit rP532277: OVERLAYS: Include <overlay>/Mk/bsd.overlay.mk (authored by bdrewery). · Explain WhyApr 21 2020, 3:51 PM
This revision was automatically updated to reflect the committed changes.
bdrewery added a commit: rP532277: OVERLAYS: Include <overlay>/Mk/bsd.overlay.mk.

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
6 linesO5: Ports Framework

Diff 70834

View Options

head/Mk/bsd.port.mk

Loading...