Unbreak editors/openoffice-* build when GCONF and GNOMEVFS are disabled

[truckman]

Summary

There is a missing dependency on devel/dbus-glib that causes the
openoffice build to fail when the GCONF and GNOMEVFS options are
disabled. When these options are enabled, one of the dependencies
added by these options brings along dbus-glib so the default
build succeeds.

There is a configure knob to control whether or not dbus-glib
is used, so follow the lead of the libreoffice port and rename
the GCONF option to GNOME and bundle both Gconf and DBUS handling
under the GNOME option.

Borrow the MMEDIA option from the libreoffice port and use
that to control the using of gstreamer.

Add a couple of missing p5-* build dependencies.

Add the --enable-gtk, --disable-kde, --disable-kde4 configure
flags so that the port does not try to build with KDE if it
is installed because compilation fails.

USE_AUTOTOOLS=autoconf -> USES=autoreconf:autoconf

Test Plan

Build with various options settings.

[truckman]

I did not bump PORTREVISION because a package with the default OPTION settings should be the same other that the explicit mention of the three dependencies.

[mat]

In D2441#44794, @truckman wrote:

I did not bump PORTREVISION because a package with the default OPTION settings should be the same other that the explicit mention of the three dependencies.

Hmmm, so, they are not the same ? Also, the options changed, gstreamer can be not there now, so the package can change, so, for me it needs a PORTREVISION bump.

But maybe I am wrong and I did not get what you said.

[truckman]

In D2441#44807, @mat wrote:

In D2441#44794, @truckman wrote:

I did not bump PORTREVISION because a package with the default OPTION settings should be the same other that the explicit mention of the three dependencies.

Hmmm, so, they are not the same ? Also, the options changed, gstreamer can be not there now, so the package can change, so, for me it needs a PORTREVISION bump.

If you build the package with the default option settings, which is what the FreeBSD package builders do, then the installed files should not change. The package metadata will have an additional dependency on devel/dbus-glib, but the dependencies installed by the GNOMEVFS and/or (former) GCONF options already installed that, which is why this problem was not previously detected.

For pkg users, bumping PORTREVISION will force them to download and reinstall essentially the same bits.

For ports users who stick with the default options, a PORTREVISION bump will force them to do a lengthy rebuild, with no obvious change in the installed bits. If they use non-default option settings, they may find their build is unbroken. A bump may also trigger a rebuild that lets them know about the option changes.

Poudriere keeps track of option settings somewhere (package metadata?). It will notice the option changes and do a rebuild whether or not PORTREVISION is bumped.

Gstreamer can only go away if you change a previously nonexistent knob to its non-default value.

I added my earlier comment because I thought this was enough of a gray area.

I'm also open to changes to the default values. The libreoffice port defaults to a stripped down version, but I was hesitant to take functionality away from existing users.

[mat]

In D2441#44838, @truckman wrote:

In D2441#44807, @mat wrote:

In D2441#44794, @truckman wrote:

I did not bump PORTREVISION because a package with the default OPTION settings should be the same other that the explicit mention of the three dependencies.

Hmmm, so, they are not the same ? Also, the options changed, gstreamer can be not there now, so the package can change, so, for me it needs a PORTREVISION bump.

If you build the package with the default option settings, which is what the FreeBSD package builders do, then the installed files should not change. The package metadata will have an additional dependency on devel/dbus-glib, but the dependencies installed by the GNOMEVFS and/or (former) GCONF options already installed that, which is why this problem was not previously detected.

For pkg users, bumping PORTREVISION will force them to download and reinstall essentially the same bits.

Well, yes, but so is adding a new dependency, pkg will detect it and say something like "reinstalling: openofice (direct dependency change)"

For ports users who stick with the default options, a PORTREVISION bump will force them to do a lengthy rebuild, with no obvious change in the installed bits. If they use non-default option settings, they may find their build is unbroken. A bump may also trigger a rebuild that lets them know about the option changes.

Poudriere keeps track of option settings somewhere (package metadata?). It will notice the option changes and do a rebuild whether or not PORTREVISION is bumped.

Gstreamer can only go away if you change a previously nonexistent knob to its non-default value.

I added my earlier comment because I thought this was enough of a gray area.

Mmmm, ok, so pkg users will get the upgrade because of new deps, and for ports users, it will eventuallly fix the build. I can live with that bending of the rules. Note that the porter's handbook is very specific, from 5.2.2.1. PORTREVISION:

PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way. That includes changes that only affect a package built with non-default options.

I'm also open to changes to the default values. The libreoffice port defaults to a stripped down version, but I was hesitant to take functionality away from existing users.

Well, ports should default to the default build of upstream, if they have options to enable/disable features, the options should reflect upstream's default.

[pi]

I'm fine with that update.