config(8): use sbuf to manage line buffers
ClosedPublic
Actions

Authored by jah on Apr 11 2020, 8:39 PM.

Details

Reviewers

kevans
imp

Commits

rS359815: config(8): use sbuf to manage line buffers

Summary

PR: 245476

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jah created this revision.Apr 11 2020, 8:39 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 11 2020, 8:39 PM

Harbormaster completed remote builds in B30424: Diff 70436.Apr 11 2020, 8:39 PM

jah retitled this revision from config(8): use sbuf to manage line buffers PR: 245476 to config(8): use sbuf to manage line buffersPR: 245476.Apr 11 2020, 8:39 PM

jah added reviewers: kevans, imp.

jah retitled this revision from config(8): use sbuf to manage line buffersPR: 245476 to config(8): use sbuf to manage line buffers.

jah edited the summary of this revision. (Show Details)

This looks fine, but given the age of config. It feels a bit like effort might be better spent on a rewrite

This revision is now accepted and ready to land.Apr 11 2020, 9:10 PM

In D24373#536140, @imp wrote:

This looks fine, but given the age of config. It feels a bit like effort might be better spent on a rewrite

TBH I had the same thought, including "how much of this even still needs to be written in C?". But that would be a big effort, and this was something simple I could do with my quarantine time.

In D24373#536143, @jah wrote:

In D24373#536140, @imp wrote:

This looks fine, but given the age of config. It feels a bit like effort might be better spent on a rewrite

TBH I had the same thought, including "how much of this even still needs to be written in C?". But that would be a big effort, and this was something simple I could do with my quarantine time.