Page MenuHomeFreeBSD

config(8): use sbuf to manage line buffers
ClosedPublic

Authored by jah on Apr 11 2020, 8:39 PM.

Details

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jah created this revision.Apr 11 2020, 8:39 PM
jah retitled this revision from config(8): use sbuf to manage line buffers PR: 245476 to config(8): use sbuf to manage line buffersPR: 245476.Apr 11 2020, 8:39 PM
jah added reviewers: kevans, imp.
jah retitled this revision from config(8): use sbuf to manage line buffersPR: 245476 to config(8): use sbuf to manage line buffers.
jah edited the summary of this revision. (Show Details)
imp accepted this revision.Apr 11 2020, 9:10 PM

This looks fine, but given the age of config. It feels a bit like effort might be better spent on a rewrite

This revision is now accepted and ready to land.Apr 11 2020, 9:10 PM
jah added a comment.Apr 11 2020, 9:20 PM
In D24373#536140, @imp wrote:

This looks fine, but given the age of config. It feels a bit like effort might be better spent on a rewrite

TBH I had the same thought, including "how much of this even still needs to be written in C?". But that would be a big effort, and this was something simple I could do with my quarantine time.

imp added a comment.Apr 11 2020, 9:35 PM
In D24373#536143, @jah wrote:
In D24373#536140, @imp wrote:

This looks fine, but given the age of config. It feels a bit like effort might be better spent on a rewrite

TBH I had the same thought, including "how much of this even still needs to be written in C?". But that would be a big effort, and this was something simple I could do with my quarantine time.

Yea. Minor clean ups are fine. It's more an aside if some has 50 or 100 changes to config rather than one or two.

kevans accepted this revision.Apr 11 2020, 11:35 PM

Much better, thanks! =-)

This revision was automatically updated to reflect the committed changes.