Differential D24333

sbappendcontrol() needs to avoid clearing M_NOTREADY on data mbufs.
ClosedPublic
Actions

Authored by markj on Apr 7 2020, 9:53 PM.

Tags

None

Referenced Files

	F169233485: D24333.id.diff
	Mon, Aug 31, 11:55 PM

	Unknown Object (File)
	Sun, Aug 30, 9:25 AM

	Unknown Object (File)
	Sat, Aug 29, 8:14 AM

	Unknown Object (File)
	Sat, Aug 29, 6:18 AM

	Unknown Object (File)
	Wed, Aug 26, 8:21 AM

	Unknown Object (File)
	Mon, Aug 24, 1:48 AM

	Unknown Object (File)
	Sun, Aug 23, 12:12 AM

	Unknown Object (File)
	Tue, Aug 18, 6:56 AM

Subscribers

Details

Reviewers

Commits

rS359779: sbappendcontrol() needs to avoid clearing M_NOTREADY on data mbufs.

Summary

If LOCAL_CREDS is set on a unix socket and we use sendfile, sendfile
will call uipc_send(PRUS_NOTREADY), which prepends a control message to
M_NOTREADY mbufs. uipc_send() then calls sbappendcontrol() instead of
sbappend(), and sbappendcontrol() was clearing M_NOTREADY, leading to
nasty results.

Test Plan

Ran a simple test case that previously triggers this bug and causes a kernel
panic due to an mbuf double free.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Apr 7 2020, 9:53 PM

Harbormaster completed remote builds in B30349: Diff 70321.Apr 7 2020, 9:53 PM

markj edited the test plan for this revision. (Show Details)Apr 7 2020, 9:56 PM

markj added a reviewer: glebius.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 8:42 PM

Closed by commit rS359779: sbappendcontrol() needs to avoid clearing M_NOTREADY on data mbufs. (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS359779: sbappendcontrol() needs to avoid clearing M_NOTREADY on data mbufs..

Herald added a subscriber: imp. · View Herald TranscriptApr 10 2020, 8:42 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

9 lines

2 lines

sys/

4 lines

Diff 70416

head/sys/kern/uipc_sockbuf.c

Loading...

head/sys/kern/uipc_usrreq.c

Loading...

head/sys/sys/sockbuf.h

Loading...