mac_framework: Remove apparently-superfluous sxlock
ClosedPublic
Actions

Authored by jah on Apr 3 2020, 11:09 PM.

Tags

None

Referenced Files

	F162957817: D24283.id70185.diff
	Sat, Jul 18, 4:58 PM

	F162904797: D24283.id70171.diff
	Sat, Jul 18, 4:18 AM

	Unknown Object (File)
	Fri, Jul 17, 8:45 AM

	Unknown Object (File)
	Wed, Jul 8, 11:17 PM

	Unknown Object (File)
	Fri, Jun 19, 7:00 PM

	Unknown Object (File)
	May 9 2026, 10:48 AM

	Unknown Object (File)
	May 6 2026, 11:15 PM

	Unknown Object (File)
	May 6 2026, 9:21 AM

View All Files

Subscribers

imp

Details

Reviewers

mjg
kib

Commits

rS359628: mac_policy: Remove mac_policy_sx

Summary

Unless there's some non-obvious performance or debugging reason for
keeping mac_policy_sx, it seems like this lock has been unnecessary
since r356120. Removing it seems to work fine with ntpd for me anyway.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jah created this revision.Apr 3 2020, 11:09 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 3 2020, 11:09 PM

Harbormaster completed remote builds in B30269: Diff 70171.Apr 3 2020, 11:09 PM

mjg accepted this revision.Apr 3 2020, 11:52 PM

This revision is now accepted and ready to land.Apr 3 2020, 11:52 PM

kib accepted this revision.Apr 4 2020, 1:15 AM

Closed by commit rS359628: mac_policy: Remove mac_policy_sx (authored by jah). · Explain WhyApr 4 2020, 4:03 AM

This revision was automatically updated to reflect the committed changes.

jah added a commit: rS359628: mac_policy: Remove mac_policy_sx.

Revision Contents
Changeset List

Path

Size

head/

sys/

security/

mac/

mac_framework.c

11 lines

Diff 70185

View Options

head/sys/security/mac/mac_framework.c

mac_framework: Remove apparently-superfluous sxlockClosedPublicActions