Differential D24227

drop GDB_LIBEXEC option
ClosedPublic
Actions

Authored by emaste on Mar 30 2020, 6:36 PM.

Details

Reviewers

jhb

Commits

rS359457: drop GDB_LIBEXEC option (now always true)

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Mar 30 2020, 6:36 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptMar 30 2020, 6:36 PM

emaste added inline comments.Mar 30 2020, 6:37 PM

gnu/usr.bin/gdb/Makefile.inc
52–56	A bit puzzled by GDB_CROSS_DEBUGGER - is the idea that we build a cross debugger for toolchain/sysroot/etc. and a standard one later?

Also this block moves from OptionalObsoleteFiles.inc to ObsoleteFiles.inc

.if ${MK_GDB} == no || ${MK_GDB_LIBEXEC} == yes
OLD_FILES+=usr/bin/gdb
OLD_FILES+=usr/bin/gdbserver
OLD_FILES+=usr/bin/kgdb
OLD_FILES+=usr/share/man/man1/gdb.1.gz
OLD_FILES+=usr/share/man/man1/gdbserver.1.gz
OLD_FILES+=usr/share/man/man1/kgdb.1.gz
.endif

Agree with moving the bits to ObsoleteFiles.inc.

gnu/usr.bin/gdb/Makefile
9	I think this means you can axe the gdbserver subdirectory as well.
gnu/usr.bin/gdb/Makefile.inc
52–56	No, this is some old gunk whereby you could manually build a cross debugger by 'cd gnu/usr.bin/gdb/; make TARGET_ARCH=foo GDB_CROSS_DEBUGGER=yes' or some such. I've never really used it, and ports gdb is already a cross-debugger for all supported architectures.