Differential D2413

Copy the attribute type if it's unknown
ClosedPublic
Actions

Authored by andrew on Apr 30 2015, 5:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 14, 12:43 PM

	Unknown Object (File)
	Tue, May 13, 10:38 AM

	Unknown Object (File)
	Fri, May 9, 3:05 PM

	Unknown Object (File)
	Thu, May 1, 2:11 PM

	Unknown Object (File)
	Thu, Apr 24, 11:39 PM

	Unknown Object (File)
	Wed, Apr 23, 5:03 PM

	Unknown Object (File)
	Tue, Apr 22, 8:13 AM

	Unknown Object (File)
	Sat, Apr 19, 6:42 PM

View All 100 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS282471: Copy new attribute types when linking. bfd will copy attributes as needed,

Summary

bfd will copy attributes as needed, however it will fail to output them if the
type is not set correctly. This can happen when it finds an attribute it hasn't
seen before, for example when building shared objects it will use the
attributes from crti.o, hwever this file has no attributes set.

This fixes a bug where attributes aren't set correctly in shared objects.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew updated this revision to Diff 5118.Apr 30 2015, 5:25 PM

andrew retitled this revision from to Copy the attribute type if it's unknown.

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

andrew added a reviewer: imp.

Herald added a reviewer: manpages. · View Herald TranscriptApr 30 2015, 5:25 PM

Herald added subscribers: imp, andrew. · View Herald Transcript

Remove Thumb-2 debugging

imp accepted this revision.Apr 30 2015, 9:16 PM

imp edited edge metadata.

This revision is now accepted and ready to land.Apr 30 2015, 9:16 PM

Closed by commit rS282471: Copy new attribute types when linking. bfd will copy attributes as needed, (authored by andrew). · Explain WhyMay 5 2015, 10:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

contrib/

binutils/

bfd/

3 lines

Diff 5199

head/contrib/binutils/bfd/elf32-arm.c

Loading...