devel/libgit2: Update to 0.99.0

[tobik]

Summary

Rust 1.43.0 (release date: 2020-04-23) is probably going to need it unless we want to switch it over to use the bundled libgit2 like rust-nightly after rP527877. If at all possible we should avoid doing that since this will at least sooner or later also affect USES=cargo ports.

Other port changes include:

• Switch to the release tarballs libgit2 now publishes
• Drop nop USES=pathfix
• Disable building tests. They are not run or hooked up in the port, so it is pointless to force everyone to build ~400 extra files. This also let's us remove USES=python:build.
• Use system libpcre instead of the bundled one
• Drop CURL option since it is no longer used and has not been for a while AFAICT

Changes: https://github.com/libgit2/libgit2/releases/tag/v0.99.0
ABI: https://abi-laboratory.pro/tracker/timeline/libgit2/

Test Plan

Builds fine in Poudriere on 12.1 amd64 (+ consumers)

Run tested Cargo to test if it can fetch the crates.io index.

[mfechner]

I tested it with gitlab and it works fine.
Thanks a lot for this upgrade, nice that they fixed all problems in the new version I reported upstream.
For reference see also here:
https://gitlab.fechner.net/mfechner/Gitlab/-/commit/da71e12c488a8c671f737909a2e85b201f0fc7df
https://gitlab.fechner.net/mfechner/Gitlab/-/commit/8a412972ee5f10323e80814f416bb8f4f6684a01
https://github.com/libgit2/libgit2/pull/5426

[tobik]

• Hook up tests
• Add ntlmclient patches (fixes test build)

Thanks a lot for this upgrade, nice that they fixed all problems in the new version I reported upstream.

IIUC, this was only for the ntlmclient and htonll problem, right? Or is there something else we need to backport?

[mfechner]

IIUC, this was only for the ntlmclient and htonll problem, right? Or is there something else we need to backport?

I only had to apply these two patch to get the ntlm part to be compiled.
I think more is not required. I have not testbuild it now, if it builds for you, please feel free to commit this, thanks a lot!

[tobik]

Thanks. Committed in rP528684 (forgot to reference this review).