sys/vm/vm_object.c
169 ↗	(On Diff #69235)	This sequence of declaration/EARLY_COUNTER initialization and SYSINIT repeats very often in your patch. Would it make sense to add e.g. COUNTER_U64_SYSINIT_EARLY that would do everything?

markj added inline comments.Mar 5 2020, 9:34 PM

sys/vm/vm_object.c
169 ↗	(On Diff #69235)	That makes sense. Maybe COUNTER_U64_DEFINE_EARLY?

kib added inline comments.Mar 5 2020, 9:41 PM

sys/vm/vm_object.c
169 ↗	(On Diff #69235)	Sure.

Use COUNTER_U64_DEFINE_EARLY.

Harbormaster completed remote builds in B29828: Diff 69268.Mar 6 2020, 3:54 PM

kib accepted this revision.Mar 6 2020, 4:22 PM

This revision is now accepted and ready to land.Mar 6 2020, 4:22 PM

Closed by commit rS358716: Use COUNTER_U64_DEFINE_EARLY() in places where it simplifies things. (authored by markj). · Explain WhyMar 6 2020, 7:10 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS358716: Use COUNTER_U64_DEFINE_EARLY() in places where it simplifies things..

Herald added a subscriber: imp. · View Herald TranscriptMar 6 2020, 7:10 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

subr_smr.c

22 lines

vfs_cache.c

29 lines

vm/

13 lines

16 lines

16 lines

21 lines

Diff 69275

View Options

head/sys/kern/subr_smr.c

View Options

head/sys/kern/vfs_cache.c

View Options

head/sys/vm/swap_pager.c

View Options

head/sys/vm/vm_object.c

View Options

head/sys/vm/vm_page.c

View Options

Use COUNTER_U64_SYSINIT() in a few places where it simplifies things.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 69275

head/sys/kern/subr_smr.c

head/sys/kern/vfs_cache.c

head/sys/vm/swap_pager.c

head/sys/vm/vm_object.c

head/sys/vm/vm_page.c

head/sys/vm/vm_reserv.c

Use COUNTER_U64_SYSINIT() in a few places where it simplifies things.
ClosedPublic
Actions

Revision Contents
Changeset List