New port: security/py-angr: multi-architecture binary analysis toolkit

[0mp]

Summary

The port builds just fine. There is only one part I am not sure about: I had to reimplement thread id retrieving (FreeBSD does not have __NR_gettid) and I am not sure if I did it correctly. I'd be grateful I someone could review it.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244562

[0mp]

Hook it to the build

[0mp]

Update the __NR_gettid reimplementation

[kaktus]

security/py-angr/files/patch-native_log.c

19 ↗

(On Diff #69098)

There is no reason to zero errno here.

22 ↗

(On Diff #69098)

if (thr_self(&tid) <0 )…

or maybe just (if it links with pthreads)

dprintf(log_fd, "[%s][%s][%d] %s():%d ", timestr, logLevels[ll].descr, pthread_getthreadid_np(), fn, ln);

23 ↗

(On Diff #69098)

tid is already of type pid_t, no reason to cast it to pid_t again.

[0mp]

• Simplify __NR_gettid implementation as suggested by kevans & kaktus.
• Add a test targett

Tests are completely broken at the moment. The port is not ready to be shipped.

[0mp]

• Do not cast tid to pid_t

[0mp]

security/py-angr/files/patch-native_log.c

22 ↗

(On Diff #69098)

I'll try it out soon.

17 ↗

(On Diff #69097)

This is the part which I am not sure about.

[0mp]

security/py-angr/files/patch-native_log.c

22 ↗

(On Diff #69098)

Yeah, seems to compile.