Page MenuHomeFreeBSD

atkbdc: convert lock into an actual mutex
AcceptedPublic

Authored by kevans on Feb 4 2020, 8:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 27 2023, 1:10 PM
Unknown Object (File)
Oct 17 2023, 9:27 PM
Unknown Object (File)
Sep 13 2023, 3:31 PM
Unknown Object (File)
Sep 6 2023, 3:19 PM
Unknown Object (File)
May 30 2023, 8:31 AM
Unknown Object (File)
May 3 2023, 6:41 AM
Unknown Object (File)
Feb 19 2023, 10:59 AM
Unknown Object (File)
Jan 13 2023, 9:15 AM
Subscribers

Details

Reviewers
imp
pstef
Summary

Using an actual mutex has the useful property that we will now record thread ownership of the lock.

The next step is to figure out if we can devise a criteria for when it's OK that a thread's proceeded to call into atkbdc without the lock so we can add some proper assertions to atkbdc. For kbd we generally use kdb_active || panicstr != NULL, but other concerns have been raised in the past about things I'm not well-versed in; e.g. IPI stop.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 29169

Event Timeline

pstef added a subscriber: pstef.

Looks good to me.

This revision is now accepted and ready to land.Sep 24 2021, 2:39 PM