Paths

Table of Contentst

Differential D23430

libusb: libusb10_hotplug: Remove lock leaks, locked sleep
ClosedPublic
Actions

Authored by • hselasky on Jan 30 2020, 4:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 1, 8:48 AM

	Unknown Object (File)
	Fri, Sep 25, 9:12 PM

	Unknown Object (File)
	Wed, Sep 16, 8:33 PM

	Unknown Object (File)
	Tue, Sep 15, 1:27 AM

	Unknown Object (File)
	Mon, Sep 14, 9:04 PM

	Unknown Object (File)
	Mon, Sep 14, 8:58 AM

	Unknown Object (File)
	Mon, Sep 14, 3:02 AM

	Unknown Object (File)
	Mon, Sep 14, 2:09 AM

Subscribers

Details

Reviewers

Commits

rS357441: MFC r357298:
rS357439: MFC r357298:
rS357438: MFC r357298:
rS357437: MFC r357298:
rS357298: Add missing mutex unlock in failure case.

Summary

Reported by: Coverity
CID: 1368773

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Jan 30 2020, 4:59 PM

Harbormaster completed remote builds in B29045: Diff 67515.Jan 30 2020, 4:59 PM

Hi,

I think only the first chunk is needed.

--HPS

• hselasky commandeered this revision.Jan 30 2020, 5:20 PM

• hselasky updated this revision to Diff 67517.

• hselasky edited reviewers, added: cem; removed: • hselasky.

• hselasky edited the summary of this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptJan 30 2020, 5:20 PM

Harbormaster completed remote builds in B29046: Diff 67517.Jan 30 2020, 5:20 PM

Hm, I don't understand where we unlock in the rest of the chunks without the changes. Maybe the breaks intentionally return a locked context, but the continues seem obviously wrong. I don't see an unlock in, e.g., libusb_hotplug_filter() which would make that safe.

cem accepted this revision.Jan 30 2020, 5:28 PM

This revision is now accepted and ready to land.Jan 30 2020, 5:28 PM

Closed by commit rS357298: Add missing mutex unlock in failure case. (authored by • hselasky). · Explain WhyJan 30 2020, 5:30 PM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rS357298: Add missing mutex unlock in failure case..

• hselasky added a commit: rS357437: MFC r357298:.Feb 3 2020, 11:04 AM

• hselasky added a commit: rS357438: MFC r357298:.

• hselasky added a commit: rS357439: MFC r357298:.

• hselasky added a commit: rS357441: MFC r357298:.Feb 3 2020, 11:18 AM

Revision Contents
Changeset List

Path

Size

head/

lib/

libusb/

libusb10_hotplug.c

4 lines

Diff 67518

head/lib/libusb/libusb10_hotplug.c

Loading...