Fix feholdexcept() on powerpc referencing the wrong struct member
ClosedPublic
Actions

Authored by renato.riolino_eldorado.org.br on Jan 27 2020, 5:43 PM.

Details

Reviewers

Commits

rS357418: [PowerPC] Fix feholdexcept() on powerpc referencing the wrong struct member

Summary

Kyua test lib/msun/fe_round_test:fe_round was failing because round mode wasn't preserved after calling lrint(). lrint uses feholdexcept() to save the current env and feupdateenv() to restore.

Test Plan

kyua test -k /usr/tests/lib/msun/Kyuafile fe_round_test:fe_round

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

renato.riolino_eldorado.org.br created this revision.Jan 27 2020, 5:43 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 27 2020, 5:43 PM

Harbormaster completed remote builds in B28951: Diff 67362.Jan 27 2020, 5:43 PM

Acknowleged. It looks to me like this one got missed in rS355656. Will take a proper look later.

OK. Got sidetracked by other float failures, but I might as well get this one in separately.

This revision is now accepted and ready to land.Feb 2 2020, 7:11 PM

Closed by commit rS357418: [PowerPC] Fix feholdexcept() on powerpc referencing the wrong struct member (authored by bdragon). · Explain WhyFeb 2 2020, 7:17 PM

This revision was automatically updated to reflect the committed changes.

bdragon added a commit: rS357418: [PowerPC] Fix feholdexcept() on powerpc referencing the wrong struct member.

Revision Contents
Changeset List

Path

Size

head/

lib/

msun/

powerpc/

fenv.h

2 lines

Diff 67668

View Options

head/lib/msun/powerpc/fenv.h

Fix feholdexcept() on powerpc referencing the wrong struct memberClosedPublicActions