Page MenuHomeFreeBSD

vfs: stop unlocking the vnode upfront in vput
ClosedPublic

Authored by mjg on Jan 24 2020, 1:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 7 2024, 8:42 PM
Unknown Object (File)
Dec 20 2023, 2:28 AM
Unknown Object (File)
Nov 10 2023, 12:33 AM
Unknown Object (File)
Nov 9 2023, 8:18 AM
Unknown Object (File)
Nov 7 2023, 11:20 PM
Unknown Object (File)
Nov 7 2023, 8:15 AM
Unknown Object (File)
Nov 6 2023, 10:11 PM
Unknown Object (File)
Oct 8 2023, 11:23 PM
Subscribers

Details

Summary

Doing so runs into races with filesystems which make half-constructed vnodes visible to other users, while depending on the chain vput -> vinactive -> vrecycle to be executed without dropping the vnode lock.

Impediments for making this work got cleared up (notably vop_unlock_post now does not do anything and lockmgr stops touching the lock after the final write). Stacked filesystems keep vhold/vdrop across unlock, which arguably can now be eliminated.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable