Page MenuHomeFreeBSD

vfs: stop unlocking the vnode upfront in vput
ClosedPublic

Authored by mjg on Jan 24 2020, 1:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 12, 1:59 PM
Unknown Object (File)
Mon, May 11, 4:33 AM
Unknown Object (File)
Mon, May 11, 3:17 AM
Unknown Object (File)
Mon, May 11, 2:17 AM
Unknown Object (File)
Fri, May 8, 6:22 AM
Unknown Object (File)
Sun, May 3, 6:03 PM
Unknown Object (File)
Fri, Apr 24, 1:32 PM
Unknown Object (File)
Fri, Apr 24, 9:41 AM
Subscribers

Details

Summary

Doing so runs into races with filesystems which make half-constructed vnodes visible to other users, while depending on the chain vput -> vinactive -> vrecycle to be executed without dropping the vnode lock.

Impediments for making this work got cleared up (notably vop_unlock_post now does not do anything and lockmgr stops touching the lock after the final write). Stacked filesystems keep vhold/vdrop across unlock, which arguably can now be eliminated.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable