Page MenuHomeFreeBSD

vfs: stop unlocking the vnode upfront in vput
ClosedPublic

Authored by mjg on Jan 24 2020, 1:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 12:43 AM
Unknown Object (File)
Fri, Oct 10, 6:08 PM
Unknown Object (File)
Fri, Oct 10, 6:08 PM
Unknown Object (File)
Fri, Oct 10, 6:08 PM
Unknown Object (File)
Fri, Oct 10, 1:09 PM
Unknown Object (File)
Sep 19 2025, 3:22 PM
Unknown Object (File)
Sep 17 2025, 5:57 AM
Unknown Object (File)
Sep 2 2025, 4:37 PM
Subscribers

Details

Summary

Doing so runs into races with filesystems which make half-constructed vnodes visible to other users, while depending on the chain vput -> vinactive -> vrecycle to be executed without dropping the vnode lock.

Impediments for making this work got cleared up (notably vop_unlock_post now does not do anything and lockmgr stops touching the lock after the final write). Stacked filesystems keep vhold/vdrop across unlock, which arguably can now be eliminated.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable