Page MenuHomeFreeBSD

vfs: stop unlocking the vnode upfront in vput
ClosedPublic

Authored by mjg on Jan 24 2020, 1:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 17, 5:24 AM
Unknown Object (File)
Sun, Mar 15, 10:49 AM
Unknown Object (File)
Sun, Mar 8, 8:11 PM
Unknown Object (File)
Sat, Mar 7, 9:15 PM
Unknown Object (File)
Sat, Mar 7, 9:15 PM
Unknown Object (File)
Sat, Mar 7, 9:15 PM
Unknown Object (File)
Thu, Feb 26, 6:42 AM
Unknown Object (File)
Jan 21 2026, 4:05 AM
Subscribers

Details

Summary

Doing so runs into races with filesystems which make half-constructed vnodes visible to other users, while depending on the chain vput -> vinactive -> vrecycle to be executed without dropping the vnode lock.

Impediments for making this work got cleared up (notably vop_unlock_post now does not do anything and lockmgr stops touching the lock after the final write). Stacked filesystems keep vhold/vdrop across unlock, which arguably can now be eliminated.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable