Page MenuHomeFreeBSD

vfs: stop unlocking the vnode upfront in vput
ClosedPublic

Authored by mjg on Jan 24 2020, 1:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 19, 7:41 AM
Unknown Object (File)
Fri, Aug 14, 6:34 AM
Unknown Object (File)
Sat, Aug 8, 7:35 PM
Unknown Object (File)
Sat, Aug 8, 5:46 PM
Unknown Object (File)
Fri, Aug 7, 11:02 PM
Unknown Object (File)
Mon, Aug 3, 2:29 PM
Unknown Object (File)
Tue, Jul 28, 4:39 PM
Unknown Object (File)
Jul 23 2026, 5:13 PM
Subscribers

Details

Summary

Doing so runs into races with filesystems which make half-constructed vnodes visible to other users, while depending on the chain vput -> vinactive -> vrecycle to be executed without dropping the vnode lock.

Impediments for making this work got cleared up (notably vop_unlock_post now does not do anything and lockmgr stops touching the lock after the final write). Stacked filesystems keep vhold/vdrop across unlock, which arguably can now be eliminated.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable