Page MenuHomeFreeBSD

vfs: stop unlocking the vnode upfront in vput
ClosedPublic

Authored by mjg on Jan 24 2020, 1:45 AM.
Tags
None
Referenced Files
F142110718: D23344.id67239.diff
Fri, Jan 16, 2:45 AM
Unknown Object (File)
Sat, Jan 10, 8:41 PM
Unknown Object (File)
Fri, Jan 9, 10:59 PM
Unknown Object (File)
Thu, Jan 8, 3:42 PM
Unknown Object (File)
Tue, Jan 6, 10:38 AM
Unknown Object (File)
Wed, Dec 31, 1:30 AM
Unknown Object (File)
Nov 28 2025, 4:36 PM
Unknown Object (File)
Nov 28 2025, 1:58 PM
Subscribers

Details

Summary

Doing so runs into races with filesystems which make half-constructed vnodes visible to other users, while depending on the chain vput -> vinactive -> vrecycle to be executed without dropping the vnode lock.

Impediments for making this work got cleared up (notably vop_unlock_post now does not do anything and lockmgr stops touching the lock after the final write). Stacked filesystems keep vhold/vdrop across unlock, which arguably can now be eliminated.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable