Do not use waitable allocation of pbuf when creating cluster for write.
ClosedPublic
Actions

Authored by kib on Dec 21 2019, 5:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 5:08 PM

	Unknown Object (File)
	Dec 3 2024, 2:43 PM

	Unknown Object (File)
	Nov 25 2024, 4:16 AM

	Unknown Object (File)
	Nov 20 2024, 1:55 PM

	Unknown Object (File)
	Nov 19 2024, 4:24 AM

	Unknown Object (File)
	Nov 6 2024, 12:13 PM

	Unknown Object (File)
	Oct 4 2024, 2:38 PM

	Unknown Object (File)
	Oct 2 2024, 9:51 PM

View All 44 Files

Subscribers

imp

Details

Reviewers

jeff
markj

Commits

rS356038: Do not use waitable allocation of pbuf when creating cluster for write.

Summary

Previously just ensuring that we do not sleep when clustering for md(4) vnode was enough.

Now, with the switch of the pbuf allocator to uma and completely broken per-subsystem pbuf limits, it might cause unbounded sleep even for non-md(4) vnodes.

Reported and tested by: pho

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Dec 21 2019, 5:17 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 21 2019, 5:17 PM

Harbormaster completed remote builds in B28278: Diff 65893.Dec 21 2019, 5:17 PM

markj accepted this revision.Dec 21 2019, 7:00 PM

This revision is now accepted and ready to land.Dec 21 2019, 7:00 PM

Closed by commit rS356038: Do not use waitable allocation of pbuf when creating cluster for write. (authored by kib). · Explain WhyDec 23 2019, 8:15 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS356038: Do not use waitable allocation of pbuf when creating cluster for write..

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

vfs_cluster.c

3 lines

Diff 65933

View Options

head/sys/kern/vfs_cluster.c

Do not use waitable allocation of pbuf when creating cluster for write.ClosedPublicActions