Page MenuHomeFreeBSD

Add support for loader.efi on arm64
ClosedPublic

Authored by andrew on Apr 14 2015, 12:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 9:57 AM
Unknown Object (File)
Mon, Apr 22, 9:27 AM
Unknown Object (File)
Sat, Apr 20, 4:41 PM
Unknown Object (File)
Sat, Mar 30, 6:05 AM
Unknown Object (File)
Mar 23 2024, 12:39 AM
Unknown Object (File)
Mar 23 2024, 12:01 AM
Unknown Object (File)
Feb 21 2024, 5:43 AM
Unknown Object (File)
Feb 20 2024, 7:51 PM
Subscribers

Details

Reviewers
emaste
imp
Summary

This adds loader.efi and boot1.efi for arm64.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

andrew retitled this revision from to Add support for loader.efi on arm64.
andrew updated this object.
andrew edited the test plan for this revision. (Show Details)
andrew added reviewers: emaste, imp.
emaste edited edge metadata.
emaste added inline comments.
sys/boot/efi/loader/arch/arm64/Makefile.inc
10

I wonder if we should just put cache.c in the arch/arm64 subdir, unless we expect libarm64 to grow over time and find non-EFI boot consumers

sys/boot/efi/loader/copy.c
64–71

Can we also expand this comment a bit explaining why we have to round up on arm and arm64?

This revision is now accepted and ready to land.Apr 14 2015, 12:58 PM

Whitespace complaints from git:

<stdin>:170: trailing whitespace.
.elif ${MACHINE_CPUARCH} == "aarch64" 
<stdin>:278: trailing whitespace.
    // No ANSI C 1999/2000 stdint.h integer width declarations 
<stdin>:282: trailing whitespace.
        // Use Microsoft C compiler integer width declarations 
<stdin>:292: trailing whitespace.
    #else             
<stdin>:295: trailing whitespace.
            // Use LP64 programming model from C_FLAGS for integer width declarations 
warning: squelched 14 whitespace errors
warning: 19 lines add whitespace errors.
sys/boot/common/Makefile.inc
12

trailing whitespace

andrew edited edge metadata.

Update based on comments

This revision now requires review to proceed.Apr 14 2015, 1:42 PM
emaste edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2015, 1:43 PM
sys/boot/efi/loader/arch/arm64/Makefile.inc
10

I expect we may gain U-Boot support for embedded devices. Some of the code for this would live in sys/boot/arm64/uboot.