Differential D2287

Remove oldnfs remnants.
ClosedPublic
Actions

Authored by trasz on Apr 14 2015, 11:12 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 31, 11:26 AM

	Unknown Object (File)
	Fri, Jan 31, 10:28 AM

	Unknown Object (File)
	Dec 9 2024, 10:21 PM

	Unknown Object (File)
	Dec 6 2024, 2:55 PM

	Unknown Object (File)
	Dec 1 2024, 3:23 PM

	Unknown Object (File)
	Nov 2 2024, 1:34 AM

	Unknown Object (File)
	Sep 28 2024, 1:35 AM

	Unknown Object (File)
	Sep 28 2024, 1:33 AM

Subscribers

Details

Reviewers

Commits

rS281691: Remove some oldnfs remnants.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

trasz updated this revision to Diff 4814.Apr 14 2015, 11:12 AM

trasz retitled this revision from to Remove oldnfs remnants..

trasz updated this object.

trasz edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptApr 14 2015, 11:12 AM

trasz added a reviewer: rmacklem.Apr 14 2015, 11:13 AM

Thanks for doing this.

Everything looks good.

I don't think it will be possible to load the old nfsserver in
FreeBSD11. Given that, you could delete the entire
"else" block in readstats() in nfsstat.c. (The else
that matches "if (deadkernel)".) It is tempting to get
rid of readstats() completely, but it might be useful to
get stats from an old kernel dump, so I guess it should
stay?

Btw, however you choose to change this, it doesn't need
another review by me. I'm happy with what you have.
(And I'll admit I find Phabricator's habit of asking for
re-reviews after every change irritating;-).

Oops, forgot to flag it reviewed. I hate web based...

This revision is now accepted and ready to land.Apr 15 2015, 7:55 PM

Closed by commit rS281691 (authored by @trasz).

Revision Contents
Changeset List

Path

Size

head/

ObsoleteFiles.inc

3 lines

etc/

defaults/

3 lines

rc.d/

6 lines

47 lines

sbin/

mount/

1 line

2 lines

mount_nfs/

3 lines

6 lines

share/

man/

man5/

8 lines

sys/

nfsclient/

3 lines

usr.bin/

nfsstat/

7 lines

usr.sbin/

nfsd/

7 lines

Diff 4895

head/ObsoleteFiles.inc

Loading...

head/etc/defaults/rc.conf

Loading...

head/etc/rc.d/mountd

Loading...

head/etc/rc.d/nfsd

Loading...

head/sbin/mount/mount.8

Loading...

head/sbin/mount/mount.c

Loading...

head/sbin/mount_nfs/Makefile

Loading...

head/sbin/mount_nfs/mount_nfs.8

Loading...

head/share/man/man5/rc.conf.5

Loading...

head/sys/nfsclient/nfs.h

Loading...

head/usr.bin/nfsstat/nfsstat.c

Loading...

head/usr.sbin/nfsd/nfsd.8

Loading...