Page MenuHomeFreeBSD

Remove oldnfs remnants.
ClosedPublic

Authored by trasz on Apr 14 2015, 11:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 9:53 PM
Unknown Object (File)
Fri, Apr 26, 8:30 PM
Unknown Object (File)
Mar 12 2024, 12:01 AM
Unknown Object (File)
Mar 11 2024, 11:57 PM
Unknown Object (File)
Mar 11 2024, 11:57 PM
Unknown Object (File)
Mar 8 2024, 4:03 AM
Unknown Object (File)
Jan 7 2024, 6:12 AM
Unknown Object (File)
Jan 7 2024, 5:54 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

trasz retitled this revision from to Remove oldnfs remnants..
trasz updated this object.
trasz edited the test plan for this revision. (Show Details)

Thanks for doing this.

Everything looks good.

I don't think it will be possible to load the old nfsserver in
FreeBSD11. Given that, you could delete the entire
"else" block in readstats() in nfsstat.c. (The else
that matches "if (deadkernel)".) It is tempting to get
rid of readstats() completely, but it might be useful to
get stats from an old kernel dump, so I guess it should
stay?

Btw, however you choose to change this, it doesn't need
another review by me. I'm happy with what you have.
(And I'll admit I find Phabricator's habit of asking for
re-reviews after every change irritating;-).

rmacklem edited edge metadata.

Oops, forgot to flag it reviewed. I hate web based...

This revision is now accepted and ready to land.Apr 15 2015, 7:55 PM
trasz updated this revision to Diff 4895.

Closed by commit rS281691 (authored by @trasz).