modernize readline support
ClosedPublic
Actions

Authored by bapt on Dec 13 2019, 11:15 AM.

Details

Reviewers

Commits

rP520635: Modernize this port

Summary

Drop the termcap option which is useless.
Drop old patches dating for the switch to elf time
Add new patches to ensure FreeBSD is treated exactly like linux is.
As there is no differences in way elf libraries can be named (note
this is int he way to be upstream).

Be futur proof about libtermcap, as we are about to drop the libtermcapw in base
to only keep one single version of ncurses (widechar friendly)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt created this revision.Dec 13 2019, 11:15 AM

Herald added a subscriber: mat. · View Herald TranscriptDec 13 2019, 11:15 AM

Harbormaster completed remote builds in B28121: Diff 65586.Dec 13 2019, 11:15 AM

mat added inline comments.Dec 13 2019, 12:48 PM

devel/readline/Makefile
41–47 ↗	(On Diff #65586)	If we were to respect our policies (the "important" bit in there), these should be a patch and an EXTRA_PATCH entry.

bapt added inline comments.Dec 13 2019, 1:17 PM

devel/readline/Makefile
41–47 ↗	(On Diff #65586)	No I strongly disagree here. because this is a REINPLACE_CMD on purpose. I plan to add proper termcap.pc in the near future in base, meaning this will have to be conditionned to it. making a REINPLACE_CMD more useful here.

mat added inline comments.Dec 13 2019, 1:31 PM

devel/readline/Makefile
41–47 ↗	(On Diff #65586)	I don't understand. You can absolutely generate the patch to apply using sed in the first place. The idea behind never using sed for static replacements is so that we detect things early when a patch is no longer required.

Add a missing patch which correcly link to libtermcap the libreadline and
contrary to the current version does not over link libhistory which does not require
a link to libtermcap.

Replace the REINPLACE_CMD by proper patch for readline.pc as requied by mat

Harbormaster completed remote builds in B28125: Diff 65593.Dec 13 2019, 1:46 PM

bapt marked 2 inline comments as done.Dec 13 2019, 3:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 22 2019, 3:01 PM

Closed by commit rP520635: Modernize this port (authored by sunpoet). · Explain Why

This revision was automatically updated to reflect the committed changes.

sunpoet added a commit: rP520635: Modernize this port.