Fix a couple of minor issues with newfs_msdos
ClosedPublic
Actions

Authored by delphij on Dec 8 2019, 1:06 AM.

Tags

None

Referenced Files

	F166176838: D22729.id65389.diff
	Wed, Aug 12, 3:40 AM

	F166142372: D22729.id.diff
	Tue, Aug 11, 11:24 PM

	Unknown Object (File)
	Mon, Aug 10, 3:31 PM

	Unknown Object (File)
	Mon, Aug 10, 3:31 PM

	Unknown Object (File)
	Mon, Aug 10, 3:30 PM

	Unknown Object (File)
	Sat, Aug 8, 5:28 AM

	Unknown Object (File)
	Fri, Aug 7, 12:32 PM

	Unknown Object (File)
	Mon, Jul 27, 4:17 PM

View All Files

Subscribers

imp

Details

Reviewers

emaste
imp

Commits

rS355513: Fix a couple of minor issues with newfs_msdos:

Summary

Do not unnecessarily strdup().
Check return value of getdiskinfo(), if it failed, bail out.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij created this revision.Dec 8 2019, 1:06 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 8 2019, 1:06 AM

Harbormaster completed remote builds in B28033: Diff 65384.Dec 8 2019, 1:06 AM

imp accepted this revision.Dec 8 2019, 1:15 AM

This revision is now accepted and ready to land.Dec 8 2019, 1:15 AM

Closed by commit rS355513: Fix a couple of minor issues with newfs_msdos: (authored by delphij). · Explain WhyDec 8 2019, 1:20 AM

This revision was automatically updated to reflect the committed changes.

delphij added a commit: rS355513: Fix a couple of minor issues with newfs_msdos:.

Revision Contents
Changeset List

Path

Size

head/

sbin/

newfs_msdos/

mkfs_msdos.c

8 lines

newfs_msdos.c

3 lines

Diff 65389

View Options

head/sbin/newfs_msdos/mkfs_msdos.c