Page MenuHomeFreeBSD
Differential D22619

Mk/Uses/cargo.mk: Do not override do-configure
ClosedPublic
Actions

Authored by tobik on Dec 1 2019, 7:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 9:41 PM
Unknown Object (File)
Sun, Sep 6, 10:45 PM
Unknown Object (File)
Sat, Sep 5, 2:00 PM
Unknown Object (File)
Fri, Sep 4, 8:34 PM
Unknown Object (File)
Fri, Sep 4, 7:41 PM
Unknown Object (File)
Fri, Sep 4, 7:07 PM
Unknown Object (File)
Fri, Sep 4, 6:30 AM
Unknown Object (File)
Fri, Sep 4, 1:01 AM
View All Files
Subscribers
mat

Details

Reviewers
jbeich
Group Reviewers
rust
O5: Ports Framework
portmgr
Commits
rP518760: Mk/Uses/cargo.mk: Do not override do-configure
Summary

Cargo vendoring can be useful even for ports that use other build
systems like Meson for the actual build. Often they use the
framework's default do-configure which USES=cargo should not
overwrite.

Remove hacks from x11/squeekboard.

Test Plan

Smoke test with devel/tokei and x11/squeekboard was ok.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobik created this revision.Dec 1 2019, 7:09 AM
Owners added a reviewer: O5: Ports Framework.Dec 1 2019, 7:09 AM
Herald added a reviewer: portmgr. · View Herald TranscriptDec 1 2019, 7:09 AM
Herald added a subscriber: mat. · View Herald Transcript
Harbormaster completed remote builds in B27869: Diff 65089.Dec 1 2019, 7:10 AM
jbeich mentioned this in rP518757: x11/squeekboard: fix typo in pkg-message.Dec 1 2019, 8:19 AM
jbeich accepted this revision.Dec 1 2019, 8:21 AM

Thanks. This would simplify maintenance of x11/squeekboard.

x11/squeekboard/Makefile
89 ↗(On Diff #65089)

Drop 1 newline as well. No need for 2 consecutive newlines.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 1 2019, 8:43 AM
Closed by commit rP518760: Mk/Uses/cargo.mk: Do not override do-configure (authored by tobik). · Explain Why
This revision was automatically updated to reflect the committed changes.
tobik added a commit: rP518760: Mk/Uses/cargo.mk: Do not override do-configure.

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
Uses/
6 linesO5: Ports Framework
games/
jaggedalliance2/
5 lines
x11/
squeekboard/
16 lines

Diff 65092

View Options

head/Mk/Uses/cargo.mk

Loading...
View Options

head/games/jaggedalliance2/Makefile

Loading...
View Options

head/x11/squeekboard/Makefile

Loading...