games/scid: fix build on arm and powerpc
ClosedPublic
Actions

Authored by pkubaj on Nov 27 2019, 7:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 9, 6:24 PM

	Unknown Object (File)
	Thu, Jan 8, 2:29 AM

	Unknown Object (File)
	Wed, Dec 31, 1:54 AM

	Unknown Object (File)
	Tue, Dec 30, 8:07 PM

	Unknown Object (File)
	Tue, Dec 30, 5:24 PM

	Unknown Object (File)
	Dec 7 2025, 9:20 PM

	Unknown Object (File)
	Nov 29 2025, 1:25 AM

	Unknown Object (File)
	Nov 26 2025, 8:59 PM

View All Files

Subscribers

None

Details

Reviewers

linimon
mat
tcberner

Commits

rP519137: games/scid: fix build on arm and powerpc

Summary

Explicitly set signed char for variables that are negative to prevent signed/unsigned issue on arm and powerpc.

PR: 242141

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pkubaj created this revision.Nov 27 2019, 7:32 PM

Harbormaster completed remote builds in B27817: Diff 64964.Nov 27 2019, 7:32 PM

Approved (builds on ppcports).

This revision is now accepted and ready to land.Nov 28 2019, 10:36 AM

Closed by commit rP519137: games/scid: fix build on arm and powerpc (authored by pkubaj). · Explain WhyDec 6 2019, 12:55 PM

This revision was automatically updated to reflect the committed changes.

pkubaj added a commit: rP519137: games/scid: fix build on arm and powerpc.

Revision Contents
Changeset List

Path

Size

head/

games/

scid/

files/

patch-src_fastgame.h

20 lines

Diff 65312

View Options

head/games/scid/files/patch-src_fastgame.h

games/scid: fix build on arm and powerpcClosedPublicActions