Differential D22312

storvsc: port a Linux patch, properly set residual data length on errors
ClosedPublic
Actions

Authored by avg on Nov 11 2019, 1:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 17, 6:02 AM

	Unknown Object (File)
	Tue, Mar 17, 3:39 AM

	Unknown Object (File)
	Tue, Mar 17, 3:23 AM

	Unknown Object (File)
	Thu, Mar 12, 3:41 PM

	Unknown Object (File)
	Sun, Mar 8, 7:29 PM

	Unknown Object (File)
	Sun, Mar 8, 1:45 PM

	Unknown Object (File)
	Sun, Mar 8, 4:04 AM

	Unknown Object (File)
	Sat, Mar 7, 2:08 PM

Subscribers

Details

Reviewers

sepherosa_gmail.com
decui_microsoft.com

Commits

rS356730: storvsc: port a Linux patch, properly set residual data length on errors

Summary

This change is based on Linux commit 40630f462824ee.
csio.resid should account for transfer_len only for success and
SRB_STATUS_DATA_OVERRUN condition.

I am not sure how exactly this change works, but I have a report from a user
that they see lots of checksum errors when running a pool scrub concurrently
with iozone -l 1 -s 100G. After applying this patch the problem cannot be
reproduced.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avg created this revision.Nov 11 2019, 1:23 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 11 2019, 1:23 PM

Harbormaster completed remote builds in B27440: Diff 64169.Nov 11 2019, 1:23 PM

add a missing header change

Harbormaster completed remote builds in B27442: Diff 64171.Nov 11 2019, 1:34 PM

avg edited the summary of this revision. (Show Details)Nov 11 2019, 1:35 PM

Ping.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2020, 1:20 PM

Closed by commit rS356730: storvsc: port a Linux patch, properly set residual data length on errors (authored by avg). · Explain Why

This revision was automatically updated to reflect the committed changes.

avg added a commit: rS356730: storvsc: port a Linux patch, properly set residual data length on errors.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hyperv/

storvsc/

hv_storvsc_drv_freebsd.c

6 lines

3 lines

Diff 66739

head/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

Loading...

head/sys/dev/hyperv/storvsc/hv_vstorage.h

Loading...