Page MenuHomeFreeBSD

Don't sanitize linker_set
ClosedPublic

Authored by matthew.bryan_isilon.com on Nov 5 2019, 3:23 AM.
Tags
None
Referenced Files
F151969345: D22239.diff
Sat, Apr 11, 8:28 PM
Unknown Object (File)
Fri, Apr 10, 2:46 PM
Unknown Object (File)
Sun, Mar 29, 12:45 PM
Unknown Object (File)
Sat, Mar 28, 5:01 PM
Unknown Object (File)
Thu, Mar 19, 3:54 PM
Unknown Object (File)
Thu, Mar 19, 2:15 AM
Unknown Object (File)
Thu, Mar 19, 1:34 AM
Unknown Object (File)
Sun, Mar 15, 12:33 PM
Subscribers

Details

Summary

The assumptions of linker_set don't play nicely with AddressSanitizer. AddressSanitizer adds a 'redzone' of zeros around globals (including those in named sections), whereas linker_set assumes they are all packed consecutively like a pointer array. So: let's annotate linker_set so that AddressSanitizer ignores it.

Adding Konstantin to the review as somebody who touched linker_set recently.

Test Plan

Manual testing to demonstrate that linker_set pointers are consecutive with no redzone. Compiled and ran the kernel and ran few kyua tests for sanity.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Nov 5 2019, 5:55 AM
kib added inline comments.
sys/sys/linker_set.h
65 ↗(On Diff #63949)

I prefer that you put the new attribute after __used.

This revision was automatically updated to reflect the committed changes.