regulator: small enhancements to regulator_shutdown

[kevans]

Summary

Highlights:

• Exit early if we're not disabling unused regulators; there's no need to take the regulator topology lock and re-evaluate this every iteration, as it's not going to change.
• Unconditionally emit a notice that we're disabling regulators so it doesn't look like we might just be taking a while to mountroot.
• Don't emit a notice that we're shutting down a regulator if it's not enabled, to reduce noise.
• Mention the outcome of the shutdown, to aide debugging and easily let developer/user collect list of regulators we actually shutdown to determine problematic one.

[manu]

sys/dev/extres/regulator/regulator.c

205 ↗

(On Diff #63862)

I would put that under if (bootverbose)

226 ↗

(On Diff #63862)

Maybe add "regulator: " in fronf of the text because just having a line with "ok" isn't really helpful.

[kevans]

sys/dev/extres/regulator/regulator.c

205 ↗

(On Diff #63862)

The comment above explains why I didn't want to put it under bootverbose. It looks like a completely unrelated failure at the moment if you're not booting verbose because this happens right around mountroot, so this is the hint that you're not having filesystem issues.

226 ↗

(On Diff #63862)

Whoops, I meant to strip the newline off the message above because this needs to be same line.

[kevans]

Chop off a newline to push status of regulator shutdown back onto the correct line with the name of the regulator.

[kevans]

Update to give and put the initial notice under bootverbose... I still don't like that we're potentially (and did, in the case that spawned this patch) shutting down regulators that make the system look like it just spontaneously lost power without emitting a notice, but I'd much prefer to get this patch in because the current situation makes it hard to debug.

[kevans]

This might need to grow a small DELAY after the "shutting down %s..." bootverbose message (if bootverbose) in case the regulator gets shutdown before we can actually print the message, but I'm still testing it to figure out why it's flakey.