Page MenuHomeFreeBSD
Differential D22126

Fix undefined behavior.
ClosedPublic
Actions

Authored by kib on Oct 23 2019, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 20, 10:42 PM
Unknown Object (File)
Thu, Nov 20, 10:41 PM
Unknown Object (File)
Thu, Nov 20, 10:41 PM
Unknown Object (File)
Thu, Nov 20, 10:33 PM
Unknown Object (File)
Sun, Nov 9, 12:42 AM
Unknown Object (File)
Oct 18 2025, 8:37 PM
Unknown Object (File)
Oct 15 2025, 4:50 PM
Unknown Object (File)
Oct 15 2025, 4:49 PM
View All 64 Files
Subscribers
None

Details

Reviewers
imp
Commits
rS353930: Fix undefined behavior.
Summary

Create a sequence point by ending a full expression for call to vspace() and use of the globals which are modified by vspace.

Reported by: imp

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Oct 23 2019, 3:54 PM
Harbormaster completed remote builds in B27170: Diff 63584.Oct 23 2019, 3:54 PM
imp accepted this revision.Oct 23 2019, 3:56 PM

Looks good to me. It's one of the two ways that I saw to fix it, and this is likely faster than the other way (pass the limit to vspace()).

This revision is now accepted and ready to land.Oct 23 2019, 3:56 PM
Closed by commit rS353930: Fix undefined behavior. (authored by kib). · Explain WhyOct 23 2019, 4:07 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS353930: Fix undefined behavior..

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
12 lines

Diff 63585

View Options

head/sys/kern/vfs_subr.c

Loading...