Fix undefined behavior.
ClosedPublic
Actions

Authored by kib on Oct 23 2019, 3:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 26 2024, 9:21 AM

	Unknown Object (File)
	Dec 25 2024, 12:52 AM

	Unknown Object (File)
	Dec 20 2024, 5:15 AM

	Unknown Object (File)
	Dec 3 2024, 6:27 AM

	Unknown Object (File)
	Oct 2 2024, 6:07 AM

	Unknown Object (File)
	Oct 1 2024, 10:04 PM

	Unknown Object (File)
	Sep 28 2024, 4:52 AM

	Unknown Object (File)
	Sep 25 2024, 3:19 AM

View All 36 Files

Subscribers

None

Details

Reviewers

imp

Commits

rS353930: Fix undefined behavior.

Summary

Create a sequence point by ending a full expression for call to vspace() and use of the globals which are modified by vspace.

Reported by: imp

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Oct 23 2019, 3:54 PM

Harbormaster completed remote builds in B27170: Diff 63584.Oct 23 2019, 3:54 PM

Looks good to me. It's one of the two ways that I saw to fix it, and this is likely faster than the other way (pass the limit to vspace()).

This revision is now accepted and ready to land.Oct 23 2019, 3:56 PM

Closed by commit rS353930: Fix undefined behavior. (authored by kib). · Explain WhyOct 23 2019, 4:07 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS353930: Fix undefined behavior..

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

vfs_subr.c

12 lines

Diff 63585

View Options

Fix undefined behavior.ClosedPublicActions