Page MenuHomeFreeBSD

Remove OSVERSION checks that do not make sense any more.
ClosedPublic

Authored by mat on Apr 2 2015, 4:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 10 2024, 2:45 PM
Unknown Object (File)
Feb 6 2024, 1:16 PM
Unknown Object (File)
Feb 6 2024, 12:26 PM
Unknown Object (File)
Jan 17 2024, 11:14 AM
Unknown Object (File)
Dec 28 2023, 6:37 AM
Unknown Object (File)
Dec 23 2023, 4:02 PM
Unknown Object (File)
Dec 20 2023, 1:21 PM
Unknown Object (File)
Dec 1 2023, 6:22 AM
Subscribers

Details

Summary

What I did was consider every OSVERSION <op> xxxx, if it is always true or false, simplify the boolean equation.

Then simplify compounds, for example (${OSVERSION} >= 900000 && ${OSVERSION} < 900021) is always true, as is (${OSVERSION} > 900002 || ${OSVERSION} < 900000 && ${OSVERSION} > 800107).

Regarding patches, when an EXTRA_PATCHES is no longer needed, I remove it, when it is always needed, I renamed it, in one case, I merged two patches.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

mat retitled this revision from to Remove OSVERSION checks that do not make sense any more..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: portmgr.
swills added a reviewer: swills.
swills added a subscriber: swills.

Macro lgtm:

This revision is now accepted and ready to land.Apr 2 2015, 5:05 PM
mat edited edge metadata.

Update with swills review.

This revision now requires review to proceed.Apr 2 2015, 5:09 PM
mat updated this revision to Diff 4633.

Closed by commit rP383107 (authored by @mat).