Page MenuHomeFreeBSD

Remove OSVERSION checks that do not make sense any more.
ClosedPublic

Authored by mat on Apr 2 2015, 4:18 PM.

Details

Summary

What I did was consider every OSVERSION <op> xxxx, if it is always true or false, simplify the boolean equation.

Then simplify compounds, for example (${OSVERSION} >= 900000 && ${OSVERSION} < 900021) is always true, as is (${OSVERSION} > 900002 || ${OSVERSION} < 900000 && ${OSVERSION} > 800107).

Regarding patches, when an EXTRA_PATCHES is no longer needed, I remove it, when it is always needed, I renamed it, in one case, I merged two patches.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mat retitled this revision from to Remove OSVERSION checks that do not make sense any more..Apr 2 2015, 4:18 PM
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: portmgr.
mat updated this revision to Diff 4604.
mat updated this object.Apr 2 2015, 4:19 PM
mat updated this object.Apr 2 2015, 4:21 PM
swills accepted this revision.
swills added a subscriber: swills.

Macro lgtm:

This revision is now accepted and ready to land.Apr 2 2015, 5:05 PM
mat edited edge metadata.Apr 2 2015, 5:09 PM
mat updated this revision to Diff 4608.

Update with swills review.

This revision now requires review to proceed.Apr 2 2015, 5:09 PM
mat closed this revision.Apr 3 2015, 11:27 AM
mat updated this revision to Diff 4633.

Closed by commit rP383107 (authored by @mat).