Page MenuHomeFreeBSD

Remove OSVERSION checks that do not make sense any more.

Authored by mat on Apr 2 2015, 4:18 PM.
Referenced Files
Unknown Object (File)
May 3 2023, 11:25 PM
Unknown Object (File)
May 3 2023, 11:22 PM
Unknown Object (File)
May 3 2023, 11:17 PM
Unknown Object (File)
May 3 2023, 9:38 PM
Unknown Object (File)
May 1 2023, 10:09 AM
Unknown Object (File)
Apr 24 2023, 2:32 PM
Unknown Object (File)
Apr 20 2023, 1:42 AM
Unknown Object (File)
Apr 17 2023, 7:45 PM



What I did was consider every OSVERSION <op> xxxx, if it is always true or false, simplify the boolean equation.

Then simplify compounds, for example (${OSVERSION} >= 900000 && ${OSVERSION} < 900021) is always true, as is (${OSVERSION} > 900002 || ${OSVERSION} < 900000 && ${OSVERSION} > 800107).

Regarding patches, when an EXTRA_PATCHES is no longer needed, I remove it, when it is always needed, I renamed it, in one case, I merged two patches.

Diff Detail

rP FreeBSD ports repository
Lint Skipped
Tests Skipped

Event Timeline

mat retitled this revision from to Remove OSVERSION checks that do not make sense any more..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: portmgr.
swills added a reviewer: swills.
swills added a subscriber: swills.

Macro lgtm:

This revision is now accepted and ready to land.Apr 2 2015, 5:05 PM
mat edited edge metadata.

Update with swills review.

This revision now requires review to proceed.Apr 2 2015, 5:09 PM
mat updated this revision to Diff 4633.

Closed by commit rP383107 (authored by @mat).