Page MenuHomeFreeBSD

Abbreviate softdep lock names.
ClosedPublic

Authored by markj on Oct 15 2019, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 2:33 AM
Unknown Object (File)
May 25 2023, 8:10 AM
Unknown Object (File)
May 14 2023, 6:39 PM
Unknown Object (File)
Apr 25 2023, 6:58 PM
Unknown Object (File)
Apr 18 2023, 10:06 PM
Unknown Object (File)
Jan 12 2023, 5:55 AM
Unknown Object (File)
Dec 22 2022, 2:10 PM
Unknown Object (File)
Dec 2 2022, 5:49 AM
Subscribers

Details

Summary

The softdep lock names are unusually long and tend to stick out in lock
profiling reports. Abbreviate them to keep consistent with our
conventional style.

Test Plan

This is how it looks without the change:

Count indv cuml rcnt     nsec Lock                   Caller                                                                                   
-------------------------------------------------------------------------------                                                               
 8676  31%  31% 0.00    10307 pmap pv list           _rw_wlock_cookie+0xbc     
 7961  28%  59% 0.00    54853 vm object              _rw_wlock_cookie+0xbc                                                                    
 6112  22%  80% 0.00    20783 tcpinp                 _rw_wlock_cookie+0xbc     
 5519  19% 100% 0.00     6301 Per-Filesystem Softdep Lock _rw_wlock_cookie+0xbc                                                               
   73   0% 100% 0.00     2857 bufobj interlock       _rw_wlock_cookie+0xbc                                                                    
    2   0% 100% 0.00      300 tidhash                _rw_wlock_cookie+0xbc                                                                    
-------------------------------------------------------------------------------

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj edited the test plan for this revision. (Show Details)
markj added a reviewer: mckusick.

This request is entirely reasonable.

This revision is now accepted and ready to land.Oct 17 2019, 11:31 PM
This revision was automatically updated to reflect the committed changes.